Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion in CacheMetadata::doCleanup #49914

Merged
merged 5 commits into from
May 18, 2023

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented May 16, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix a race in CacheMetadata::doCleanup. Closes #49386

@kssenii kssenii requested a review from devcrafter May 16, 2023 11:57
@kssenii kssenii marked this pull request as ready for review May 16, 2023 11:57
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label May 16, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented May 16, 2023

This is an automated comment for commit adebac1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@kssenii
Copy link
Member Author

kssenii commented May 16, 2023

Unit tests (asan) — PASSED record not found.

broken in master

Stateless tests (release, DatabaseReplicated) [4/4] — fail: 1

00992_system_parts_race_condition_zookeeper_long - flaky in master

@kssenii kssenii requested a review from devcrafter May 17, 2023 10:30
@kssenii kssenii force-pushed the fix-assertion-in-do-cleanup branch from a36b128 to f2dbcb5 Compare May 17, 2023 14:27
Copy link
Member

@devcrafter devcrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment

@kssenii
Copy link
Member Author

kssenii commented May 18, 2023

Unit tests (asan) — PASSED record not found.

broken on master:

==13==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f00000cca10 at pc 0x555d81667d61 bp 0x7efec3c8edd0 sp 0x7efec3c8edc8
READ of size 8 at 0x7f00000cca10 thread T3999 (ThreadPool)
    #0 0x555d81667d60 in IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0::operator()() const build_docker/./src/IO/Resource/tests/gtest_resource_manager_hierarchical.cpp:93:17
    #1 0x555d81667d60 in decltype(std::declval<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&>()()) std::__1::__invoke[abi:v15000]<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&>(IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&) build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
    #2 0x555d81667d60 in decltype(auto) std::__1::__apply_tuple_impl[abi:v15000]<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&, std::__1::tuple<>&>(IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&, std::__1::tuple<>&, std::__1::__tuple_indices<>) build_docker/./contrib/llvm-project/libcxx/include/tuple:1789:1
    #3 0x555d81667d60 in decltype(auto) std::__1::apply[abi:v15000]<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&, std::__1::tuple<>&>(IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&, std::__1::tuple<>&) build_docker/./contrib/llvm-project/libcxx/include/tuple:1798:1
    #4 0x555d81667d60 in ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0>(IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&&)::'lambda'()::operator()() build_docker/./src/Common/ThreadPool.h:228:13
    #5 0x555d81667d60 in decltype(std::declval<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0>()()) std::__1::__invoke[abi:v15000]<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0>(IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&&)::'lambda'()&>(IOResourceDynamicResourceManager_Fairness_Test::TestBody()::$_0&&) build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB::CacheMetadata::doCleanup() Logical error: 'false'.
4 participants