-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make projections production-ready #49719
Conversation
This is an automated comment for commit 8a6e07f with description of existing statuses. It's updated for the latest CI running
|
@@ -560,6 +560,7 @@ class IColumn; | |||
M(Bool, asterisk_include_alias_columns, false, "Include ALIAS columns for wildcard query", 0) \ | |||
M(Bool, optimize_skip_merged_partitions, false, "Skip partitions with one part with level > 0 in optimize final", 0) \ | |||
M(Bool, optimize_on_insert, true, "Do the same transformation for inserted block of data as if merge was done on this block.", 0) \ | |||
M(Bool, optimize_use_projections, true, "Automatically choose projections to perform SELECT query", 0) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way it could be marked as an alias for allow_experimental_projection_optimization
(#45659)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azat I like the idea, please do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this will allow to remove pr-backward-incompatible
label I guess
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make projections production-ready. Add the
optimize_use_projections
setting to control whether the projections will be selected for SELECT queries. The settingallow_experimental_projection_optimization
is obsolete and does nothing.Note: it was supposed to make projections as non-experimental a long time ago, but the previous attempt was done with failure - the setting
allow_experimental_projection_optimization
was marked as obsolete but not obsoleted.