Fix Attaching a table with non-existent ZK path does not increase the ReadonlyReplica metric

[wzb5212]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix Attaching a table with non-existent ZK path does not increase the ReadonlyReplica metric, may be fix #16045

ATTACH TABLE test_no_zk UUID 'a50b7933-59b2-49ce-8db6-59da3c9b4413'
(
    `i` Int8,
    `d` Date
)
ENGINE = ReplicatedMergeTree('no_zk', 'replica')
ORDER BY tuple()

0 rows in set. Elapsed: 0.007 sec.

Row 1:
──────
database:                    test
table:                       test_no_zk
engine:                      ReplicatedMergeTree
is_leader:                   0
can_become_leader:           1
is_readonly:                 1
is_session_expired:          0
future_parts:                0
parts_to_check:              0
zookeeper_path:              /no_zk
replica_name:                replica
replica_path:                /no_zk/replicas/replica
columns_version:             -1
queue_size:                  0
inserts_in_queue:            0
merges_in_queue:             0
part_mutations_in_queue:     0
queue_oldest_time:           1970-01-01 08:00:00
inserts_oldest_time:         1970-01-01 08:00:00
merges_oldest_time:          1970-01-01 08:00:00
part_mutations_oldest_time:  1970-01-01 08:00:00
oldest_part_to_get:
oldest_part_to_merge_to:
oldest_part_to_mutate_to:
log_max_index:               0
log_pointer:                 0
last_queue_update:           1970-01-01 08:00:00
absolute_delay:              1681923781
total_replicas:              0
active_replicas:             0
lost_part_count:             0
last_queue_update_exception:
zookeeper_exception:         Code: 999. Coordination::Exception: /no_zk/log (No node). (KEEPER_EXCEPTION) (version 23.4.1.1)
replica_is_active:           {}

1 row in set. Elapsed: 0.006 sec.

SELECT *
FROM system.metrics
WHERE metric = 'ReadonlyReplica'

Query id: ff118b33-1835-49e9-8d23-aff67234e944

┌─metric──────────┬─value─┬─description────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ReadonlyReplica │     1 │ Number of Replicated tables that are currently in readonly state due to re-initialization after ZooKeeper session loss or due to startup without ZooKeeper configured. │
└─────────────────┴───────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

[CLAassistant]

All committers have signed the CLA.

[den-crane]

please add a test

[wzb5212]

please add a test

ok.

[wzb5212]

please add a test

I added an integration test, please take a look.

[wzb5212]

@den-crane some ci test failed , please take a look.

[tavplubix]

some ci test failed , please take a look.

You can take a look yourself. There's a "Details" link for each failed check, it opens a report with a list of failed tests and links to relevant logs. Also you can use our public CI database to check if some test is flaky/broken in master (example). But these failures are not related to your changes, so it's okay.

Integration tests (asan) [3/6] - test_backup_restore_on_cluster is flaky - #45486
Stateless tests (release, analyzer) - it's a new check with new analyzer, and it's broken in master
Stateless tests (ubsan) [2/2] - 01676_clickhouse_client_autocomplete is flaky

[wzb5212]

some ci test failed , please take a look.

You can take a look yourself. There's a "Details" link for each failed check, it opens a report with a lost of failed tests and links to relevant logs. Also you can use our public CI database to check if some test is flaky/broken in master (example). But these failures are not related to your changes, so it's okay.

Integration tests (asan) [3/6] - test_backup_restore_on_cluster is flaky - #45486 Stateless tests (release, analyzer) - it's a new check with new analyzer, and it's broken in master Stateless tests (ubsan) [2/2] - 01676_clickhouse_client_autocomplete is flaky

thanks.