(0.95.6) Pin GPUArrays version + fix GPU testing pipeline #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-silvestri
changed the title
navidcy
approved these changes
Jan 10, 2025
navidcy
added
GPU 👾
glwagner
approved these changes
Jan 10, 2025
|
|
|
Seems that is up but in a weird state? https://buildkite.com/clima/oceananigans/builds/20098#0194536b-13e4-4608-9244-a1f27f86d12d/34-43 |
navidcy
changed the title
|
Does this closes #4036? |
navidcy
added a commit
to CliMA/ClimaOcean.jl
that referenced
this pull request
Jan 12, 2025
trying out to see if scalar operations came with v0.95.7 and changes introduced by CliMA/Oceananigans.jl#4037
Not really, because we want to be able to use the new |
navidcy
added a commit
to CliMA/ClimaOcean.jl
that referenced
this pull request
Jan 20, 2025
) * don't add / twice * add missing deps + compats * temporarily only leave the ECCO2 example on * GLMakie -> CairoMakie; BuoyancyModels -> BuoyancyFormulations * update * code alignment * add docs/Manifest.toml * Update Project.toml trying out to see if scalar operations came with v0.95.7 and changes introduced by CliMA/Oceananigans.jl#4037 * Update Project.toml * homogenize compats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of Oceananigans functionalities are broken at the moment because of a change in
GPUArrays(see issue #4036)This PR pins to a previous
GPUArraysversion to keep the repository (and the CI) functioning. Once the issue has been resolved we can remove this constraint.