Feedback #2
Assignees
Labels
Comments
ali-ramadhan
added
feature 🌟
|
Thanks for the feedback @ranjanan !
|
navidcy
added a commit
that referenced
this issue
Jan 16, 2022
Split tests into smaller bits and pieces (take #2)
tomchor
added a commit
that referenced
this issue
Mar 23, 2023
…#2) (#2990) * ZDirection -> NegativeZDirection (doctests pass locally atm) * @info -> @warn * comment parts of the documentation * uncomment tilted bbl example (docs still build locally w this change) * bring back other doc pages (still builds) * full docs * adds review suggestions * bugfix * better unit-vector validation + fix coriolis tests --------- Co-authored-by: Navid C. Constantinou <[email protected]>
simone-silvestri
added a commit
that referenced
this issue
Apr 11, 2023
* remove tullio dependency * bugfix * add abs to abstract operations * solved the issue * probably not super efficient * indices for gridmetricoperations * just remove tullio * change timescale definition * do not introduce indices now * Update src/Advection/cell_advection_timescale.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/Diagnostics/cfl.jl * accurate_cell_advection_timescale -> cell_advection_timescale --------- Co-authored-by: Gregory L. Wagner <[email protected]> Co-authored-by: Navid C. Constantinou <[email protected]>
simone-silvestri
added a commit
that referenced
this issue
Sep 19, 2023
simone-silvestri
added a commit
that referenced
this issue
Sep 19, 2023
…cFreeSurfaceModel` and `NonhydrostaticModel` (#3125) * comment * fixed tag problems * bugfix * Update scalar_biharmonic_diffusivity.jl * Update src/Distributed/multi_architectures.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Distributed/partition_assemble.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/ImmersedBoundaries/ImmersedBoundaries.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/ImmersedBoundaries/active_cells_map.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Distributed/interleave_comm_and_comp.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Clean up batched tridiagonal solver and vertically implicit solver * Fix bug in batched tridiagonal solver * bugfix * Try to fix multi region immersed boundary issue * Hopefully fix immersed boundary grid constructor * Another fix * fixed project and manifest * convert instead of FT * export KernelParameters * remove FT * removed useless where FT * small bugfix * update manifest * remove unbuffered communication * little bit of a cleanup * removed `views` comment * couple of bugfixes * fixed tests * probably done * same thing for nonhydrostatic model * include file * bugfix * prepare for nonhydrostatic multiregion * also here * bugfix * other bugfix * fix closures * bugfix * simplify * 2D leith requires 2 halos! * AMD and Smag require 1 halo! * wrong order * correct halo handling for diffusivities * correct Leith formulation + fixes * `only_local_halos` kwarg in `fill_halo_regions!` * bugfix * FT on GPU * bugfix * bugfix * last bugfix? * removed all offsets from kernels + fixed all tests * fix `_compute!` * finished * fixed broken tests * fixed docs * miscellaneous changes * bugfix * removed tests for vertical subdivision * test corner passing * correction * retry * fixed all problems * Added a validation example * fixed tests * try new test * fill send buffers in the correct place * fixed comments * define async * pass the grid * bugfix * fix show method * RefValue for mpi_tag * comment * add catke preprint * remove warning; add ref to catke preprint * some code cleanup * correct the example * Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl Co-authored-by: Navid C. Constantinou <[email protected]> * bugfix * Refactor unit tests * Generalize regridding for lat-lon * bugfix * Add newline * small correction * new tests * bugfix * bugfix * back for testing * update manifest * more options * more * finished * test hypothesis * fixed bug - correct speed now * add space * bugfix * test * more info * removed left-right connected computation * bugfix * remove info * improve * typo * bugfix * bugfix * correct comments * bugfix * bugfix prescribed velocities * fixes * ok on mac * bugfix * bug fixed * bugfixxed * new default * bugfix * remove <<<<HEAD * bugfix PrescribedVelocityFields * default in another PR * bugfix * flat grids only in Grids * last bugfix * bugfix * try partial cells * bugfix * bugfix * Update test_turbulence_closures.jl * small fixes * rework IBG and MRG * Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl * small bugfix * remove multiregion ibg with arrays for the moment * bugfix * little cleaner * fixed tests * see what the error is * allow changing halos from checkpointer * test it * finally fixed it * better naming * bugfix * bugfix * bugfix * bugfix * removed useless tendency * small fix * dummy commit * fix active cell map * comment * bugfix * bugfix * removed useless tendency * maybe just keep it does not harm too much * should have fixed it? * let's go now * done * bugfix * no need for this * convert Δt in time stepping * maximum * minimum substeps * more flexibility * bugfix * mutlidimensional * fallback methods * test a thing * change * chnage * change * change * update * update * new offsets + return to previous KA * bugfix * bugfixxed * remove debugging * going back * more robus partitioning * quite new * bugfix * updated Manifest * build with 1.9.3 * switch boundary_buffer to required_halo_size * bugfix * Update src/Models/HydrostaticFreeSurfaceModels/single_column_model_mode.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl Co-authored-by: Gregory L. Wagner <[email protected]> * bugfix * biharmonic requires 2 halos * buggfix * compute_auxiliaries! * bugfix * fixed it * little change * some changes * bugfix * bugfix * bugfixxed * another bugfix * compute_diffusivities! * required halo size * all fixed * shorten line * fix comment * remove abbreviation * remove unused functions * better explanation of the MPI tag * Update src/ImmersedBoundaries/active_cells_map.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Solvers/batched_tridiagonal_solver.jl Co-authored-by: Navid C. Constantinou <[email protected]> * change name * docstring * name change on rank * interior active cells * calculate -> compute * fixed tests * do not compute momentum in prescribed velocities * DistributedComputations * DistributedComputations part #2 * bugfix * fixed the docs --------- Co-authored-by: Navid C. Constantinou <[email protected]> Co-authored-by: Gregory L. Wagner <[email protected]>
navidcy
added a commit
that referenced
this issue
Sep 20, 2023
…cFreeSurfaceModel` and `NonhydrostaticModel` (#3125) * comment * fixed tag problems * bugfix * Update scalar_biharmonic_diffusivity.jl * Update src/Distributed/multi_architectures.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Distributed/partition_assemble.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/ImmersedBoundaries/ImmersedBoundaries.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/ImmersedBoundaries/active_cells_map.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Distributed/interleave_comm_and_comp.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Clean up batched tridiagonal solver and vertically implicit solver * Fix bug in batched tridiagonal solver * bugfix * Try to fix multi region immersed boundary issue * Hopefully fix immersed boundary grid constructor * Another fix * fixed project and manifest * convert instead of FT * export KernelParameters * remove FT * removed useless where FT * small bugfix * update manifest * remove unbuffered communication * little bit of a cleanup * removed `views` comment * couple of bugfixes * fixed tests * probably done * same thing for nonhydrostatic model * include file * bugfix * prepare for nonhydrostatic multiregion * also here * bugfix * other bugfix * fix closures * bugfix * simplify * 2D leith requires 2 halos! * AMD and Smag require 1 halo! * wrong order * correct halo handling for diffusivities * correct Leith formulation + fixes * `only_local_halos` kwarg in `fill_halo_regions!` * bugfix * FT on GPU * bugfix * bugfix * last bugfix? * removed all offsets from kernels + fixed all tests * fix `_compute!` * finished * fixed broken tests * fixed docs * miscellaneous changes * bugfix * removed tests for vertical subdivision * test corner passing * correction * retry * fixed all problems * Added a validation example * fixed tests * try new test * fill send buffers in the correct place * fixed comments * define async * pass the grid * bugfix * fix show method * RefValue for mpi_tag * comment * add catke preprint * remove warning; add ref to catke preprint * some code cleanup * correct the example * Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl Co-authored-by: Navid C. Constantinou <[email protected]> * bugfix * Refactor unit tests * Generalize regridding for lat-lon * bugfix * Add newline * small correction * new tests * bugfix * bugfix * back for testing * update manifest * more options * more * finished * test hypothesis * fixed bug - correct speed now * add space * bugfix * test * more info * removed left-right connected computation * bugfix * remove info * improve * typo * bugfix * bugfix * correct comments * bugfix * bugfix prescribed velocities * fixes * ok on mac * bugfix * bug fixed * bugfixxed * new default * bugfix * remove <<<<HEAD * bugfix PrescribedVelocityFields * default in another PR * bugfix * flat grids only in Grids * last bugfix * bugfix * try partial cells * bugfix * bugfix * Update test_turbulence_closures.jl * small fixes * rework IBG and MRG * Update src/TurbulenceClosures/vertically_implicit_diffusion_solver.jl * small bugfix * remove multiregion ibg with arrays for the moment * bugfix * little cleaner * fixed tests * see what the error is * allow changing halos from checkpointer * test it * finally fixed it * better naming * bugfix * bugfix * bugfix * bugfix * removed useless tendency * small fix * dummy commit * fix active cell map * comment * bugfix * bugfix * removed useless tendency * maybe just keep it does not harm too much * should have fixed it? * let's go now * done * bugfix * no need for this * convert Δt in time stepping * maximum * minimum substeps * more flexibility * bugfix * mutlidimensional * fallback methods * test a thing * change * chnage * change * change * update * update * new offsets + return to previous KA * bugfix * bugfixxed * remove debugging * going back * more robus partitioning * quite new * bugfix * updated Manifest * build with 1.9.3 * switch boundary_buffer to required_halo_size * bugfix * Update src/Models/HydrostaticFreeSurfaceModels/single_column_model_mode.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl Co-authored-by: Gregory L. Wagner <[email protected]> * bugfix * biharmonic requires 2 halos * buggfix * compute_auxiliaries! * bugfix * fixed it * little change * some changes * bugfix * bugfix * bugfixxed * another bugfix * compute_diffusivities! * required halo size * all fixed * shorten line * fix comment * remove abbreviation * remove unused functions * better explanation of the MPI tag * Update src/ImmersedBoundaries/active_cells_map.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Solvers/batched_tridiagonal_solver.jl Co-authored-by: Navid C. Constantinou <[email protected]> * change name * docstring * name change on rank * interior active cells * calculate -> compute * fixed tests * do not compute momentum in prescribed velocities * DistributedComputations * DistributedComputations part #2 * bugfix * fixed the docs --------- Co-authored-by: Navid C. Constantinou <[email protected]> Co-authored-by: Gregory L. Wagner <[email protected]>
simone-silvestri
added a commit
that referenced
this issue
Aug 7, 2024
…rms (#3279) * change * change * update * update * first commit * transpose? * new offsets + return to previous KA * bugfix * bugfixxed * remove debugging * more transposes * continuing * It works!!!! * works! * will it work? * works? * It works!!!! * not all the fill halos * validation * no unflattened tuple * correction * better test * bugfixxes * other bugfix * cleaned up a bit * removed * finally it runs * works!! * preparing for tridiagonal * all bugfixes * finally it works! * left a show in there * it works!!! * last bugfix * this will work * buffer only for y * now it will work! * now we cooking * some comments * now it works? * now we can probably test it out? * back as before * final fix * works also in bounded directions * going back * fixed everything * more robus partitioning * quite new * bugfix * updated Manifest * build with 1.9.3 * switch boundary_buffer to required_halo_size * bugfix * Update src/Models/HydrostaticFreeSurfaceModels/single_column_model_mode.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl Co-authored-by: Gregory L. Wagner <[email protected]> * bugfix * biharmonic requires 2 halos * buggfix * compute_auxiliaries! * bugfix * fixed it * little change * some changes * bugfix * bugfix * bugfixxed * another bugfix * compute_diffusivities! * required halo size * all fixed * shorten line * fix comment * remove abbreviation * remove unused functions * better explanation of the MPI tag * Update src/ImmersedBoundaries/active_cells_map.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Solvers/batched_tridiagonal_solver.jl Co-authored-by: Navid C. Constantinou <[email protected]> * change name * docstring * name change on rank * interior active cells * calculate -> compute * fixed tests * do not compute momentum in prescribed velocities * DistributedComputations * DistributedComputations part #2 * bugfix * comment * starting tests * test the ffts * bugfix * small change * add transpose test * MPI.VBuffer * fixed these tests for the moment * using * transpose * fixed the distributed FFT tests * not yet tridiagonal * fulfill requirements * fix doctest * add distributed script * bugfix * update to current syntax * couple of changes * more instructions * remove pencilstuff * at least precompiles * modify test * simplify * run test * correct comment * bugfix * grammar * more comments * fix tests * new commit * fixing the injection * bugfix distributed * new syntax * comment * comment * couple of TODOs * comment * distributed hydrostatic * added hydrostatic simulation * fixed tests * small change * testing also regression on nonhydrostatic * remove pencilarrays * some small, bugfixes * small bugfix * new manifest * switch to on_architecture * test an hypothesis * update the ocean large eddy regression test * correct rayleigh benard regression * correct thermal regression test * more bugfixes * bugfixes for the regression tests * some corrections * another bugfix for regression * test quickly on gpus * define fallback for reconstruct_global_grid * gpu tests * last bugfix to distribute regression tests * do not do the thermal bubble for the moment * adding gpu distributed solvers tests * finally it works for bounded * make sure everything is on the CPU * make sure everything is on the CPU * test distributed poisson also on the GPU * at least the poisson solve works, next the regression tests * another bug in the tests * some docs * some naming changes * change file naming * bugfix * bugfix distributed regression * wrong indices * leave out other tests for the moment * make sure we use correct archs for regression * non hydrostatic regression archs * remove test file * this should make all test pass * archs outside * move `archs` to the right position * add comments * fix doctests * small name change * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * change to named tuple * allow Flat directions and FieldTimeSeries * implementing child architecture for grids * solve_poisson_in_spectral_space! * adding some docs * docs formatting * use julia v1.10.4 * resolve deps * use julia v1.10.4 * bump patch release * formatting * formatting * formatting * adapting manifest * bugfix * fix `partition_coordinate` * spit out error + fixes to docs * more docfixes * yet another docfix * make sure validation example works * add a couple of comments * Update validation/distributed_simulations/distributed_nonhydrostatic_turbulence.jl Co-authored-by: Gregory L. Wagner <[email protected]> * retry the build * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/distributed_transpose.jl Co-authored-by: Tomas Chor <[email protected]> * Update test/test_distributed_transpose.jl Co-authored-by: Tomas Chor <[email protected]> * docs changes * add a configuration validation * remove the `ArgumentError` * alignment * fix tests * make names very explicit * some more explanation * add more docstring * bugfix * address a couple of comments * add link to MPI docs * bump to 0.92 * version 91.6 * retry the tests * few tweaks in the docstring * Update distributed_fft_based_poisson_solver.jl --------- Co-authored-by: Gregory L. Wagner <[email protected]> Co-authored-by: Navid C. Constantinou <[email protected]> Co-authored-by: Tomas Chor <[email protected]>
simone-silvestri
added a commit
that referenced
this issue
Aug 9, 2024
* some changes * bugfix * bugfix * bugfixxed * another bugfix * compute_diffusivities! * required halo size * all fixed * shorten line * fix comment * remove abbreviation * remove unused functions * better explanation of the MPI tag * Update src/ImmersedBoundaries/active_cells_map.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Solvers/batched_tridiagonal_solver.jl Co-authored-by: Navid C. Constantinou <[email protected]> * change name * docstring * name change on rank * interior active cells * calculate -> compute * fixed tests * do not compute momentum in prescribed velocities * DistributedComputations * DistributedComputations part #2 * bugfix * comment * starting tests * test the ffts * bugfix * small change * add transpose test * MPI.VBuffer * fixed these tests for the moment * using * transpose * fixed the distributed FFT tests * not yet tridiagonal * fulfill requirements * fix doctest * add distributed script * bugfix * update to current syntax * couple of changes * more instructions * remove pencilstuff * at least precompiles * modify test * simplify * run test * correct comment * bugfix * grammar * more comments * fix tests * new commit * fixing the injection * bugfix distributed * new syntax * comment * comment * couple of TODOs * comment * distributed hydrostatic * added hydrostatic simulation * fixed tests * small change * testing also regression on nonhydrostatic * remove pencilarrays * some small, bugfixes * small bugfix * new manifest * switch to on_architecture * test an hypothesis * update the ocean large eddy regression test * correct rayleigh benard regression * correct thermal regression test * more bugfixes * bugfixes for the regression tests * some corrections * another bugfix for regression * test quickly on gpus * define fallback for reconstruct_global_grid * gpu tests * last bugfix to distribute regression tests * do not do the thermal bubble for the moment * adding gpu distributed solvers tests * finally it works for bounded * make sure everything is on the CPU * make sure everything is on the CPU * test distributed poisson also on the GPU * at least the poisson solve works, next the regression tests * another bug in the tests * some docs * some naming changes * change file naming * bugfix * bugfix distributed regression * wrong indices * leave out other tests for the moment * make sure we use correct archs for regression * non hydrostatic regression archs * remove test file * this should make all test pass * archs outside * move `archs` to the right position * add comments * fix doctests * small name change * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * change to named tuple * try it out * allow Flat directions and FieldTimeSeries * implementing child architecture for grids * solve_poisson_in_spectral_space! * adding some docs * docs formatting * use julia v1.10.4 * resolve deps * use julia v1.10.4 * bump patch release * formatting * formatting * formatting * adapting manifest * should run * test all * bugfix * bugfix * some progress * bugfix * fix assemble coordinate * loos like it's working! * fix docs * comments * comments * rayeigh benard stretched test * somoe validation * fix `partition_coordinate` * spit out error + fixes to docs * more docfixes * yet another docfix * make sure validation example works * add a couple of comments * Update validation/distributed_simulations/distributed_nonhydrostatic_turbulence.jl Co-authored-by: Gregory L. Wagner <[email protected]> * retry the build * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/distributed_transpose.jl Co-authored-by: Tomas Chor <[email protected]> * Update test/test_distributed_transpose.jl Co-authored-by: Tomas Chor <[email protected]> * docs changes * adding a validation to the configuration * add a configuration validation * remove the `ArgumentError` * alignment * clarify a bit the sizes in `TransposableField` * fixed tests * fix tests * make names very explicit * some more explanation * add more docstring * bugfix * address a couple of comments * add link to MPI docs * bump to 0.92 * version 91.6 * retry the tests * few tweaks in the docstring * Update distributed_fft_based_poisson_solver.jl * some comments to the tridiagonal solver * test the new solver * bugfix * add configuration validation * change order of operations * formatting * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * changed error message * add new comments * better explanation * Update src/DistributedComputations/distributed_fft_based_poisson_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * some typo * typo * retry build * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Gregory L. Wagner <[email protected]> * address comments * add functionality for unstretched solver * other additions * no more need for `XYRegularGrid` and so on! * some bugfixes * another bugfix * bugfixes * formatting * fix tests * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/distributed_fft_tridiagonal_solver.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/distributed_grids.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/partition_assemble.jl Co-authored-by: Tomas Chor <[email protected]> * Update src/DistributedComputations/partition_assemble.jl Co-authored-by: Tomas Chor <[email protected]> * another bugfix * change emojii for distributed pipeline * another bugfix * another typo fix --------- Co-authored-by: Navid C. Constantinou <[email protected]> Co-authored-by: Gregory L. Wagner <[email protected]> Co-authored-by: Tomas Chor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pmap(others =@parallel, DistributedArrays, MPIArrays)The text was updated successfully, but these errors were encountered: