Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert enchantment to mutation #60031

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Aug 8, 2022

Summary

None

Purpose of change

I tested my changes on #59988 then realized I didn't want to make changes to SUN_MAGE. Adjusted the name but didn't realize SUN_MAGE is different than normal traits. This should correct what was going wrong.

Describe the solution

@dseguin changes look correct.

Describe alternatives you've considered

None

Testing

Tested and it works. Though I'm disappointed that fireball doesn't set flammables on fire.

Additional context

@Maleclypse Maleclypse requested a review from KorGgenT as a code owner August 8, 2022 17:56
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 8, 2022
@dseguin dseguin merged commit 416457f into CleverRaven:master Aug 9, 2022
@Maleclypse Maleclypse deleted the Librarian-bug branch August 9, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants