Fix building with clang-cl under visual studio. #60030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Building with clang-cl used to work. Now it doesn't. Make it work again.
Describe the solution
Don't include
<cxxabi.h>when compiling in msvc mode, which means with cl.exe or clang-cl.exe. This used to be gated behind some logic that tested for_WIN32and included different headers, but in the new location we should explicitly test_MSC_VER.Describe alternatives you've considered
None crossed my mind.
Testing
Build with clang-cl integration in visual studio.
Additional context
This doesn't fix linking with lld-link, which seems to object to vcpkg's automatic lib arguments, but it allows compiling cataclysm lib at least.