Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pebbles can be stored in a stone pouch #55470

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

ZombieZilla
Copy link
Contributor

@ZombieZilla ZombieZilla commented Feb 17, 2022

Summary

Bugfixes "Stone pouch now can hold pebbles"

Purpose of change

Addresses and fixes #55462

Describe the solution

Stone pouch now holds 80 pebbles (2.4L & 5.6kg) or 10 rocks (2.5L & 6.6kg)

Describe alternatives you've considered

Testing

Spawned in pebbles, successfully inserted them into the stone pouch

Additional context

None

@ZombieZilla ZombieZilla changed the title Update bandolier.json Pebbles can be stored in a stone pouch Feb 17, 2022
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 17, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 17, 2022
@NetSysFire NetSysFire added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things labels Feb 17, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 17, 2022
@chrispikula
Copy link
Contributor

chrispikula commented Feb 18, 2022

Given that pebbles are "count": 10,, wouldn't this mean 800 pebbles in the pouch?

{
"type": "AMMO",
"id": "pebble",
"name": { "str": "pebble" },
"symbol": "=",
"color": "light_gray",
"description": "A small rock, useful as ammunition for slingshots.",
"material": [ "stone" ],
"volume": "250 ml",
"weight": "66 g",
"ammo_type": "pebble",
"flags": [ "TRADER_AVOID" ],
"damage": { "damage_type": "bullet", "amount": 2 },
"range": 10,
"dispersion": 14,
"loudness": 0,
"count": 10,
"effects": [ "NEVER_MISFIRES", "NON_FOULING" ]
},

@ZombieZilla
Copy link
Contributor Author

Given that pebbles are "count": 10,, wouldn't this mean 800 pebbles in the pouch?

Nope, it stores only 80 pebbles

@Rivet-the-Zombie Rivet-the-Zombie merged commit f0f6f19 into CleverRaven:master Feb 20, 2022
@ZombieZilla ZombieZilla deleted the stone_pebble_pouch branch March 18, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pebbles do not fit in the stone pouch
5 participants