Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional TLC Finales #55445

Merged
merged 15 commits into from
Feb 20, 2022
Merged

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Feb 16, 2022

Summary

Content "Additional TLC Finales"

Purpose of change

Adds two new finale rooms to the TCL since some other stuff is happening soon 👀

Also Migo need some love.

Describe the solution

TODO:

  • Add the rooms
  • Make them spawn
  • Make the rewards

Adds two new unique items and support infrastructure for them.

Iridescent Carapace Ballistic Plates
These plates are living tissue teased into the form of armor inserts. They can ablate and shatter like normal ceramic plates however given time they also grow back (24h). they can also become overgrown and become incredibly uncomfortable to wear. They include a lab notes manual with the recipe to manually shave the plates down to a reasonable size.

Overgrown:
image

Standard:
image

Undergrown:
image

Completely wrecked:
image

and the manual:
image

and craft:
image

Second Skin Fluid Under Armor
A disgusting second skin of non-neutonian fluid. Found as a strange choker, when activated it covers most of your body in a shock absorbing fluid. It is permanently filthy and needs to be repaired with blood and a proprietary feeding system

Off:
image

On:
image

Repair Kit (repairing requires blood but it needs water as charges):
image

As well this PR adds two new materials (Unobtanium) its a not particularly special metal but can't be repaired.
Non newtonian alien fluid which is the good stuff and is repaired with blood.

A new mob which is a captured mostly dead MIGO.

And adds a spawn for the MIGO Biotech.

Describe alternatives you've considered

Not adding cool new sci-fi items

Testing

Everything works and is tested.
Can't fast forward time to test plates, need to actually step through the turns.

Additional context

Room 1 (plates):
image

Room 2 (suit):
image

Biotech Room (small modification of the east vaults):
image

@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A slimy layer of liquid has completely engulfed your body from the neck down and seems to move with you, the sensation is uncomfortable. The liquid seems bound to a choker made from odd materials that seems to hum slightly, the inside reads 'CAREFUL CHOKING HAZARD' with an arrow pointing down. The ooze flows frealy covering your entire body but never crossing the choker to get to your head.
  • This sheaf of papers seems to describe mainenance on a new form of ballistic armor. "the regenerative plates though promising for field use do require maintenance or combat to stop from becoming overgrown"
  • erradicated
  • plate of scarred fleshs
  • the necklace hums and the liquid gets vaccumed back into it.
  • undergrown iridescent carapace plate
  • undergrown iridescent carapace plates

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 16, 2022
@bombasticSlacks bombasticSlacks marked this pull request as draft February 16, 2022 19:45
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 16, 2022
@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Feb 16, 2022
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 16, 2022
@bombasticSlacks bombasticSlacks marked this pull request as ready for review February 16, 2022 23:00
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 16, 2022
@TealcOneill
Copy link
Contributor

I'm curious, how does the second skin work with players that have the squeamish trait?

@bombasticSlacks
Copy link
Contributor Author

I'm curious, how does the second skin work with players that have the squeamish trait?

I thought it would work, that your character needs to remove them however that seems to not be the case. I'll fix it in a separate PR.

@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 17, 2022
@Jarewill
Copy link
Contributor

Oooo, this looks interesting.
However I have two questions regarding the second skin item.

For one, the odd choker is on the strapper layer, while the actual second skin is on the skin layer.
Seeing as the items transform into each other, it might cause annoyance having to move the item from the outermost layer to the innermost layer. (Unless the layer moving is automatic)
Though it still might seem odd that the strapped layer choker just disappears when the skin activates.

Another question I have regarding it is if it can be taken off once active.
I don't know how exactly this item functions, but if it's really a liquid, would it really be able to be taken off?

The ability to repair it when it's inactive might also be useful.

@bombasticSlacks
Copy link
Contributor Author

For one, the odd choker is on the strapper layer, while the actual second skin is on the skin layer.
Seeing as the items transform into each other, it might cause annoyance having to move the item from the outermost layer to the innermost layer. (Unless the layer moving is automatic)
Though it still might seem odd that the strapped layer choker just disappears when the skin activates.

I'm going to rearrange this so the item is a gorget and will cover the shoulders and be skintight even when off to avoid the rearranging.

Another question I have regarding it is if it can be taken off once active.
I don't know how exactly this item functions, but if it's really a liquid, would it really be able to be taken off?

I debated making custom code for it transforming back when taken off but it seems like it would just confuse players. it doesn't behave exactly like liquid so if you wanted to pull the suit off while it was deployed I imagine the non-neutonian fluid would just congeal and be gross but still behave similar to a soft fabric.

The ability to repair it when it's inactive might also be useful.

It means you could repair it with copper which I don't want, however I think I have a fix for that planned.

@Jarewill
Copy link
Contributor

I debated making custom code for it transforming back when taken off but it seems like it would just confuse players. it doesn't behave exactly like liquid so if you wanted to pull the suit off while it was deployed I imagine the non-neutonian fluid would just congeal and be gross but still behave similar to a soft fabric.

Alright, I gotcha.

It means you could repair it with copper which I don't want, however I think I have a fix for that planned.

I can fully understand that, I wouldn't want such a unique item to be repairable with just copper either.
I know there's the "repairs_like" property for items, but I don't know how exactly it works.

@bombasticSlacks
Copy link
Contributor Author

I can fully understand that, I wouldn't want such a unique item to be repairable with just copper either.
I know there's the "repairs_like" property for items, but I don't know how exactly it works.

thats for items with no crafting recipe so that you can give them an associated repair difficulty. So it's more saying "this is about as hard to repair as X". What I'm going to do is move the material from copper to an alien metal with no repair options and that will fix it.

@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A heavy duty gorget made from odd materials that hums slightly, it feels damp to the touch and there is a mechanical button of some kind on the front. The inside reads "CAREFUL CHOKING HAZARD! THIS WAY DOWN".
  • A slimy layer of liquid has completely engulfed your body from the neck down and seems to move with you, the sensation is uncomfortable. The liquid appears bound to the article at your neck made from odd materials that hum slightly, the inside reads "CAREFUL CHOKING HAZARD! THIS WAY DOWN". The ooze flows freely covering your entire body but never crossing the gorget to get to your head.
  • resonating gorget
  • resonating gorgets

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • resonating gorgets

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 18, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 18, 2022
@kevingranade kevingranade merged commit 2250ecb into CleverRaven:master Feb 20, 2022
@Drew4484 Drew4484 mentioned this pull request Mar 7, 2022
3 tasks
@Raikiri
Copy link

Raikiri commented Mar 3, 2023

I encountered everything added in this PR and it's awesome. I wish CDDA had much much more weird and rare things like this.

I also tried washing the second skin in my washing machine. Well I guess it was worth a try :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants