Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of obligatory flags to MA techs #55403

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Feb 15, 2022

Summary

None

Purpose of change

Gate certain melee techs behind having all of an arbitrary list of character flags to facilitate e.g. multi-arm strikes being forbidden when any one arm is disabled / overencumbered.

Describe the solution

Add required_char_flags_all, defining a list of character flags the character needs to trigger a given tech.

Describe alternatives you've considered

Make it a pair of [ "FLAG", count], but this allows requiring a combination of different flags.

Testing

Used the WIP 4 Tentacles mutation adding 4 tentacles, each with an armed/unarmed/single tech and the conditional flags 4TENTACLE_1 through _4. The unarmed attack requires all four flags, the others are satisfied by any one. The unarmed tech triggered as expected with all four flags and stopped triggering when one of the arms got damaged below the health limit, the other techs triggered until no tentacles were left.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 15, 2022
@NetSysFire NetSysFire added Limbs Limbs, mutable limbs, and code related to them. Melee Melee weapons, tactics, techniques, reach attack [C++] Changes (can be) made in C++. Previously named `Code` labels Feb 15, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 15, 2022
@kevingranade kevingranade merged commit 0024b85 into CleverRaven:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them. Melee Melee weapons, tactics, techniques, reach attack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants