Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only time or failure rate for proficiency if both don't apply #55330

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented Feb 13, 2022

Summary

Interface "Show only time or failure rate for proficiency if both don't apply"

Purpose of change

Fixes #48597

Describe the solution

Add extra translation strings for if the only the time or failure rate is not 1.0 as well as the existing state of both.

Describe alternatives you've considered

  • Rephrase the description to allow for combining the strings rather than basically duplicating them.
  • Ignore the failure only rate because recipes are unlikely to do this. (I only set skills to 10 and scrolled through the recipes to see if one triggered that block, but there are more recipes in books that might do this and future recipes may add a reason for this to be covered. Better safe than add future bugs?)
  • Leave as is

Testing

Loaded up the game, looked at a few recipes to verify proficiency description is updated.

Additional context

Before:
image
After:
image

Validate other recipes still show both:
image

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 13, 2022
@Maleclypse Maleclypse added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Feb 14, 2022
@kevingranade kevingranade merged commit 1ed949a into CleverRaven:master Feb 17, 2022
@haveric haveric deleted the proficiency-description branch February 25, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect text on proficiency failure rate.
3 participants