JSON flag for default collapse of container contents #51434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Enhancement / Feature>
actual-nh
reviewed
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "JSON flag for default collapse of container contents"
Purpose of change
Adds JSON control over the default collapse of containers in inventory view.
Describe the solution
The flag COLLAPSE_CONTENTS when added to a container will make it collapsed by default. Anything - item groups etc - that is created in that container will be collapsed.
Collapse is done in the item constructor so will not affect existing items in the game.
Items set to collapse in JSON: IFAK, wallets, first aid kits, MRE.
Describe alternatives you've considered
Testing
Found natural sources of the items and opened inventory. MREs and wallets from soldiers, and first aid kits from evac shelter basements. Containers were collapsed.
Also confirmed that settings persist on a save/load.
Additional context