-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new worn unarmed weapons #49118
Add new worn unarmed weapons #49118
Conversation
Add new worn unarmed weapons (Impact Knuckles and Skewer Knuckles)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This recipe should be handled by their common tool quality of bolt turning, not specific items that happen to have bolt turning.
Co-authored-by: LaVeyanFiend <[email protected]>
Co-authored-by: LaVeyanFiend <[email protected]>
Changes as per code review: Updated original post with new screenshots |
You will need to call out in #dev-help to have a dev run tests for you |
Those on site |
Looks to me all tests are triggered automatically on commit since they're running now |
Re-PR'd in #49914 which also addresses merge conflicts and the move towards the new armor portion format |
Summary
Content "Add Impact and Skewer Knuckles"
Purpose of change
Add content to unarmed combat caused by the void left over by #48503. By this point, only 4 unarmed weapons exist in the game. I saw this as an opportunity to use infrastructure added in #41209 for top layer gloves to be used as unarmed weapons to give them a useful niche of their own.
Describe the solution
Create Impact Knuckles and Skewer Knuckles with stats based relative to existing items.
Impact Knuckles has 12 bash (same damage as a pipe), and Skewer Knuckles with 10 pierce ( same damage as a steel sewing awl). From a weapons damage perspective, they are relatively weak combat stat-wise, Impact knuckles being barely stronger than a cudgel which is craftable seconds after starting the game, and Skewer Knuckles being only slightly stronger than a steak knife. This is intentional since unarmed weapons should not be stronger than armed weapons due to leverage and reach.
Describe alternatives you've considered
Not make them at all
Testing
Impact Knuckles:

Skewer Knuckles:

Additional context
Additional changes in this PR:
Moved previously unarmed weapons out of the unarmed json file since they are no longer unarmed weapons.
Removed Bolt cutters from studded gloves since studs do not need bolt cutters to make, only a hammer.