Gloves are messing up punch speed

[souricelle]

Describe the bug

Many items that cover your hands have an attack speed value. If you attack while wearing one of these items, they're potentially slowing your attacks down very badly. An easy example of this is the Field Combat Exoskeleton, which has an attack speed of 700. So picking up an empty suit of power armor and walloping someone with it is costing the same amount of moves as punching someone while wearing it, whether it's powered or not.

Wielded weapons are unaffected by this bug.

Steps To Reproduce

1. Equip and power a suit of power armor
2. Punch something
3. Take 7+ seconds to do so despite being able to stab with a knife at the normal speed

Expected behavior

Gloves should not be affecting attack speed whatsoever, except for their hand encumbrance.

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2004
• Game Version: 0.E-10114-gd55d4a1 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions]
  ]

[Salty-Panda]

Can confirm, happened to me with RM13 combat armor and Taekwondo

[Salty-Panda]

Caused by #41209

[Salty-Panda]

Suggested fix:
In

        if( found_glove ) {
           cur_weapon->set_flag( flag_UNARMED_WEAPON );
           unarmed_flag_set = true;
       }

also temporarily reduce move_cost of item (probably not possible to change directly, so by manipulating weight), depending on covered body parts. The coverage data can be found in body_parts.json iirc.

[hexagonrecursion]

Could not reproduce. Punching while wearing a powered on field combat exoskeleton costs 57 points

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
• Game Version: 20b0c03 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Bionic Professions [package_bionic_professions]
  ]

[Salty-Panda]

Already fixed in PR linked a bit above, its author incorrectly mentioned this issue, so github didn't close this automatically.