Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): different env vars should not be in the code block #513

Merged
merged 4 commits into from
Feb 4, 2025
Merged

fix(nodejs): different env vars should not be in the code block #513

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fd8ab7
fix(nodejs): different env vars should not be in the code block
Jan 28, 2025
ba58231
Merge branch 'main' into nodejs-fix-env-vars
Yoda-BZH Jan 28, 2025
d7bc967
Merge branch 'main' into nodejs-fix-env-vars
juliamrch Feb 3, 2025
d6b5fd7
Merge branch 'main' into nodejs-fix-env-vars
cnivolle Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions content/doc/applications/javascript/nodejs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@

* `CC_NODE_DEV_DEPENDENCIES=install`: Development dependencies will be installed.
* `CC_NODE_DEV_DEPENDENCIES=ignore`: Development dependencies will not be installed.
* `NODE_ENV=production, CC_NODE_DEV_DEPENDENCIES=install`: Development dependencies will be installed.
* `NODE_ENV=production, CC_NODE_DEV_DEPENDENCIES=ignore`: Development dependencies will not be installed.
* `NODE_ENV=production` and `CC_NODE_DEV_DEPENDENCIES=install`: Development dependencies will be installed.

Check warning on line 95 in content/doc/applications/javascript/nodejs.md

View workflow job for this annotation

GitHub Actions / Run Vale Linter 

[vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

Raw Output:
{"message": "[Google.Will] Avoid using 'will'.", "location": {"path": "content/doc/applications/javascript/nodejs.md", "range": {"start": {"line": 95, "column": 90}}}, "severity": "WARNING"}

Check warning on line 95 in content/doc/applications/javascript/nodejs.md

View workflow job for this annotation

GitHub Actions / Run Vale Linter 

[vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('be installed').

Raw Output:
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('be installed').", "location": {"path": "content/doc/applications/javascript/nodejs.md", "range": {"start": {"line": 95, "column": 95}}}, "severity": "INFO"}
* `NODE_ENV=production` and `CC_NODE_DEV_DEPENDENCIES=ignore`: Development dependencies will not be installed.

Check warning on line 96 in content/doc/applications/javascript/nodejs.md

View workflow job for this annotation

GitHub Actions / Run Vale Linter 

[vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

Raw Output:
{"message": "[Google.Will] Avoid using 'will'.", "location": {"path": "content/doc/applications/javascript/nodejs.md", "range": {"start": {"line": 96, "column": 89}}}, "severity": "WARNING"}

Check warning on line 96 in content/doc/applications/javascript/nodejs.md

View workflow job for this annotation

GitHub Actions / Run Vale Linter 

[vale] reported by reviewdog 🐶
[Google.Contractions] Use 'won't' instead of 'will not'.

Raw Output:
{"message": "[Google.Contractions] Use 'won't' instead of 'will not'.", "location": {"path": "content/doc/applications/javascript/nodejs.md", "range": {"start": {"line": 96, "column": 89}}}, "severity": "INFO"}

Check warning on line 96 in content/doc/applications/javascript/nodejs.md

View workflow job for this annotation

GitHub Actions / Run Vale Linter 

[vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('be installed').

Raw Output:
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('be installed').", "location": {"path": "content/doc/applications/javascript/nodejs.md", "range": {"start": {"line": 96, "column": 98}}}, "severity": "INFO"}
* `NODE_ENV=production`: Package manager (NPM / Yarn) default behavior. Development dependencies will not be installed.
* Neither `NODE_ENV` nor `CC_NODE_DEV_DEPENDENCIES` are defined: Package manager (NPM / Yarn) default behavior. Development dependencies will be installed.

Expand Down Expand Up @@ -182,7 +182,7 @@
{{< tabs items="npm, Corepack" >}}

{{< tab >}}**Install with `npm`**:

```bash
CC_NODE_BUILD_TOOL="custom"
CC_PRE_BUILD_HOOK="npm install -g pnpm"
Expand All @@ -192,7 +192,7 @@
{{< /tab >}}

{{< tab >}}**Enable with Corepack**:

```bash
CC_NODE_BUILD_TOOL="custom"
CC_PRE_BUILD_HOOK="corepack enable pnpm"
Expand Down
Loading