Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emails command #874

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add emails command #874

wants to merge 4 commits into from

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Jan 25, 2025

This PR adds an emails commands to add, remove(-all) secondary emails to a user account, set the primary email, list emails, and open the emails management page in the Console.

I've added an email parser to validate emails. It uses a simple regex to avoid corner cases. There is another proposition in comment, chose the one you prefer.

This PR includes and uses the 2 utils.js functions introduced in #873

@davlgd davlgd added this to the 3.13 milestone Jan 25, 2025
@davlgd davlgd self-assigned this Jan 25, 2025
@davlgd davlgd requested a review from a team as a code owner January 25, 2025 14:45
Copy link

github-actions bot commented Jan 25, 2025

🔎 A preview has been automatically published:

  • 🐧 linux 7c96e2dc0bdbeb11e17f68cf91c2309ac8559076508b05214ceb57a13ec4264a
  • 🍏 macos 4e0de0fb30e1e8ef7022a1420b8ac34d4faaac11036608ef3ff04c71be513abd
  • 🪟 win edc3c0e12e31b5a37e7b4bc3116ecf67443ca236fc91ea0fa83eafc6ee6b9a8b

This preview will be deleted once this PR is closed.

Copy link
Collaborator

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done David. I have several comments and some fixes to apply (some of them are due to API limitations or bugs).

src/parsers.js Outdated Show resolved Hide resolved
bin/clever.js Outdated Show resolved Hide resolved
src/commands/emails.js Outdated Show resolved Hide resolved
src/commands/emails.js Outdated Show resolved Hide resolved
src/commands/emails.js Show resolved Hide resolved
src/commands/emails.js Show resolved Hide resolved
src/commands/emails.js Show resolved Hide resolved
src/commands/emails.js Outdated Show resolved Hide resolved
src/commands/emails.js Outdated Show resolved Hide resolved
src/models/emails-api.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants