build(cdn): remove generated icon files from rollup config #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberttran-cc
requested review from
hsablonniere,
Galimede,
florian-sanders-cc,
pdesoyres-cc and
HeleneAmouzou
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/build/fix-cdn-config/index.html. This preview will be deleted once this PR is closed. |
pdesoyres-cc
approved these changes
Jan 11, 2024
hsablonniere
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Well done @roberttran-cc, I just tried it locally and it's perfect! 👍 👏
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898
How to review
(export VERSION=12.0.0 && npm run cdn-release:build)taskdist-cdn/cc-remix.icons-{HASH}.jsfile contentsRelated impacts
Also impacts the NPM build: remix icons are no more "officially" included. More precisely, they are still available but not at the project root. This behavior is intended.
Reviewers
Two will be sufficient.