refactor(cc-article-list)!: migrate to the new smart component design #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdesoyres-cc
requested review from
hsablonniere,
roberttran-cc,
Galimede,
florian-sanders-cc and
HeleneAmouzou
and removed request for
hsablonniere and
roberttran-cc
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/new-smart-design/cc-article-list/index.html. This preview will be deleted once this PR is closed. |
roberttran-cc
approved these changes
Jan 4, 2024
florian-sanders-cc
approved these changes
Jan 9, 2024
pdesoyres-cc
force-pushed
the
new-smart-design/cc-article-list
branch
4 times, most recently
from
19b66c5 to
0752a99
Compare
Galimede
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Historically limit was optional. With how the smart works now it makes it no longer possible. While it's not much of an inconvenience here, (the console provides a limit anyway), can you change the doc cc-article-list.md to reflect it and so that the examples may work again?
HeleneAmouzou
approved these changes
Jan 24, 2024
roberttran-cc
approved these changes
Jan 29, 2024
BREAKING CHANGE: the properties have changed - `state`: new property containing the whole state - `articles`: property has been deleted as it is now part of the state - `error`: property has been deleted as it is now part of the state Fixes #921
pdesoyres-cc
force-pushed
the
new-smart-design/cc-article-list
branch
from
0752a99 to
4711406
Compare
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921
What is this?
How to review?