Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cc-pricing-product): add translations for dedicated and is-migratable features #835

Merged

Conversation

florian-sanders-cc
Copy link
Contributor

@florian-sanders-cc florian-sanders-cc commented Sep 19, 2023

Fixes #804

How to review?

  • check the commit (from GitHub should be just fine),
  • check the cc-pricing-product - Data loaded - (fake product) story in both English and French. The first product table should show the following categories:
    • "Migration tool" / "Outil de migration" (boolean type)
    • "Dedicated" / "Dédié" (boolean type)

@github-actions
Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-pricing-product/add-missing-feature-translations/index.html.

This preview will be deleted once this PR is closed.

Copy link
Contributor

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏

Copy link
Member

@roberttran-cc roberttran-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 LGTM

@florian-sanders-cc florian-sanders-cc merged commit cebb109 into master Sep 19, 2023
@florian-sanders-cc florian-sanders-cc deleted the cc-pricing-product/add-missing-feature-translations branch September 19, 2023 07:50
@github-actions
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cc-pricing: add new feature translations
3 participants