eslint: enable some rules from the import plugin in the generic clever cloud config #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
force-pushed
the
eslint/enable-import-extensions
branch
from
d3721bf to
32b13aa
Compare
florian-sanders-cc
changed the title
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/eslint/enable-import-extensions/index.html. This preview will be deleted once this PR is closed. |
|
🔎 The preview has been automatically deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
importplugin ineslint-config-clever-cloud-esm:no-unresolved: even though TypeScript already handles this fairly well, it's better to be safe than sorry + the config is meant to be generic and could be used in projects that don't have TypeScript enabled (thanks @Galimede for pointing that out),extensions: same reason as above but TypeScript doesn't always handle the extension requirement (for plain imports likeimport './my-component.js';.The
namedremains disabled because it doesn't seem to work well. We'll deal with that when we handle #1273How to review?