Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-logs: easy-quick-wins #1091

Merged
merged 5 commits into from
Jun 28, 2024
Merged

cc-logs: easy-quick-wins #1091

merged 5 commits into from
Jun 28, 2024

Conversation

pdesoyres-cc
Copy link
Contributor

@pdesoyres-cc pdesoyres-cc commented Jun 20, 2024

This PR contains som easy quick wins:

Copy link
Contributor

🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/logs/easy-quick-win/index.html.

This preview will be deleted once this PR is closed.

Copy link
Contributor

@florian-sanders-cc florian-sanders-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from very small nitpicks, looks great! Gg 😎

src/components/cc-logs/cc-logs.js Outdated Show resolved Hide resolved
src/components/cc-logs/logs-input-controller.js Outdated Show resolved Hide resolved
Copy link
Member

@Galimede Galimede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪

@pdesoyres-cc pdesoyres-cc force-pushed the logs/easy-quick-win branch from cfcbbd9 to f30dfb6 Compare June 28, 2024 09:38
- `Home`: move focus on first line
- `End`: move focus on last line
- `Ctrl` + `Shift` + `Home`: expands the selection from the first line
- `Ctrl` + `Shift` + `End`: expands the selection to the last line

Fixes #1009
@pdesoyres-cc pdesoyres-cc force-pushed the logs/easy-quick-win branch from f30dfb6 to 8dc21b7 Compare June 28, 2024 09:39
@pdesoyres-cc pdesoyres-cc merged commit c77667e into master Jun 28, 2024
4 checks passed
@pdesoyres-cc pdesoyres-cc deleted the logs/easy-quick-win branch June 28, 2024 09:45
Copy link
Contributor

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants