Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: resize observer loop error makes tests fail #821

Closed
florian-sanders-cc opened this issue Aug 28, 2023 · 0 comments · Fixed by #823 or #825
Closed

Tests: resize observer loop error makes tests fail #821

florian-sanders-cc opened this issue Aug 28, 2023 · 0 comments · Fixed by #823 or #825
Assignees
@florian-sanders-cc
Labels
bug Something isn't working easy-quick-win maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)

Comments

@florian-sanders-cc
Copy link
Contributor

Context

It looks like Chrome now uses the same error message as Firefox for the resize loop error (see #808).

When we merge cc-logs, we'll have a proper way to handle this but in the meantime, we need to add this error message to the ignore list.
@florian-sanders-cc florian-sanders-cc added bug Something isn't working maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...) easy-quick-win labels Aug 28, 2023
@florian-sanders-cc florian-sanders-cc self-assigned this Aug 28, 2023
florian-sanders-cc added a commit that referenced this issue Aug 28, 2023
@florian-sanders-cc
fix(tests): add another resize loop error message to the ignore list
d3e1872 
Fixes #821
@florian-sanders-cc florian-sanders-cc mentioned this issue Aug 28, 2023
Merged
florian-sanders-cc added a commit that referenced this issue Aug 28, 2023
@florian-sanders-cc
fix(tests): add another resize loop error message to the ignore list
b3010a4 
Fixes #821
@clevercloud-ci clevercloud-ci mentioned this issue Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florian-sanders-cc florian-sanders-cc

Labels
bug Something isn't working easy-quick-win maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)
Projects
None yet
Milestone
No milestone
1 participant
@florian-sanders-cc