Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-img: use text value as alt value for the inner <img> tag #726

Closed
florian-sanders-cc opened this issue Mar 15, 2023 · 0 comments · Fixed by #873 or #876
Closed

cc-img: use text value as alt value for the inner <img> tag #726

florian-sanders-cc opened this issue Mar 15, 2023 · 0 comments · Fixed by #873 or #876
Assignees
@HeleneAmouzou
Labels
a11y Related to accessibility bug Something isn't working

Comments

@florian-sanders-cc
Copy link
Contributor

florian-sanders-cc commented Mar 15, 2023 •
edited by hsablonniere
Loading

Context

The cc-img component has a text prop that is used to display a text when the image is not loaded.
The alt attribute of the <img> tag inside the component is always empty and there is no way to set it from outside the component.

Solutions

Either use text value as alt value (when there is no error), or introduce a separate accessible-name prop.
@florian-sanders-cc florian-sanders-cc added bug Something isn't working a11y Related to accessibility labels Mar 15, 2023
HeleneAmouzou added a commit that referenced this issue Oct 4, 2023
@HeleneAmouzou
fix(cc-img): populate alt value
637430a 
Fixes #726
HeleneAmouzou added a commit that referenced this issue Oct 23, 2023
@HeleneAmouzou
refactor(cc-img): replace prop text by accessibleName
8c0af1d 
Fixes #726
@HeleneAmouzou HeleneAmouzou mentioned this issue Oct 23, 2023
Merged
HeleneAmouzou added a commit that referenced this issue Oct 24, 2023
@HeleneAmouzou
refactor(cc-img): replace text prop in components using cc-img
3e6e32a 
Fixes #726
HeleneAmouzou added a commit that referenced this issue Oct 30, 2023
@HeleneAmouzou
fix(cc-img): populate alt value
a5d2d2b 
Fixes #726
@clevercloud-ci clevercloud-ci mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeleneAmouzou HeleneAmouzou

Labels
a11y Related to accessibility bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@florian-sanders-cc @HeleneAmouzou