Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-notice: init component #343

Closed
Galimede opened this issue Nov 18, 2021 · 1 comment · Fixed by #622 or #644
Closed

cc-notice: init component #343

Galimede opened this issue Nov 18, 2021 · 1 comment · Fixed by #622 or #644
Assignees
Labels
enhancement New feature or request

Comments

@Galimede
Copy link
Member

This would be an improved version of current cc-error that would handle several states :

@hsablonniere hsablonniere changed the title create cc-notice component cc-notice: init component Mar 8, 2022
@hsablonniere hsablonniere added the enhancement New feature or request label Mar 8, 2022
@Galimede
Copy link
Member Author

Galimede commented Aug 9, 2022

Here are some thoughts and questions that I have about the component right now:

Questions

  • Of what I have seen other design systems seem to use their alert as their base component for their toaster => Do we use the design of the cc-toast for our cc-notice?
  • Do we need a close button?
  • How de we handle accessibility of the component?
  • Do we keep the behavior of cc-error with no border by default and a mode with border and box-shadow?
  • What about the loading mode that cc-error had?
  • Do we need to have the confirm state?
  • Otherwise do we provide a slot so put whatever you want in the content? (like a confirm button?)
  • Do we still want to call it cc-notice we thought about this name when writing the issue because we were implementing a notice mode on the cc-error. Of what I've seen design systems tend more to call it alert. (I have also seen banner)
  • Heading seems not to be present on what I have seen elsewhere. On most of them there's only a message.
  • Do we want to provide an option to change the alignment of the text?

Previews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants