cc-pricing-product.smart-addon: addonFeatures param should be optional
#1174
Assignees
Labels
bug
Something isn't working
Comments
florian-sanders-cc
added a commit
that referenced
this issue
Oct 30, 2024
Smart components: - The `addonFeatures` context parameter of the `cc-pricing-product.smart-addon` component is now optional as it should always have been (default value: `[]` meaning that all features are displayed by default). - The `zoneId` context parameter of both `cc-pricing-product.smart-addon` & `cc-pricing-product.smart-runtime` is now optional (default value: `'par'`). BREAKING CHANGE: the component no longer supports hard coded change rate Prices displayed in pricing components are no longer computed based on hard coded change rate. Prices related to the selected currency come from the API priceSytem endpoint. The component also relies on the new `state` prop for data coming from the API. This means that some types for the component properties have changed: - `currency` is now a `string` (ISO 4217 currency code), - `product` has been removed, - `state` has been added to replace `product`, - `product.state` is now `state.type`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. Fixes #1167 #1109 #1174 #1176
florian-sanders-cc
added a commit
that referenced
this issue
Oct 30, 2024
Smart components: - The `addonFeatures` context parameter of the `cc-pricing-product.smart-addon` component is now optional as it should always have been (default value: `[]` meaning that all features are displayed by default). - The `zoneId` context parameter of both `cc-pricing-product.smart-addon` & `cc-pricing-product.smart-runtime` is now optional (default value: `'par'`). BREAKING CHANGE: the component no longer supports hard coded change rate Prices displayed in pricing components are no longer computed based on hard coded change rate. Prices related to the selected currency come from the API priceSytem endpoint. The component also relies on the new `state` prop for data coming from the API. This means that some types for the component properties have changed: - `currency` is now a `string` (ISO 4217 currency code), - `product` has been removed, - `state` has been added to replace `product`, - `product.state` is now `state.type`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. Fixes #1167 #1109 #1174 #1176
florian-sanders-cc
added a commit
that referenced
this issue
Nov 20, 2024
Smart components: - The `addonFeatures` context parameter of the `cc-pricing-product.smart-addon` component is now optional as it should always have been (default value: `[]` meaning that all features are displayed by default). - The `zoneId` context parameter of both `cc-pricing-product.smart-addon` & `cc-pricing-product.smart-runtime` is now optional (default value: `'par'`). BREAKING CHANGE: the component no longer supports hard coded change rate Prices displayed in pricing components are no longer computed based on hard coded change rate. Prices related to the selected currency come from the API priceSytem endpoint. The component also relies on the new `state` prop for data coming from the API. This means that some types for the component properties have changed: - `currency` is now a `string` (ISO 4217 currency code), - `product` has been removed, - `state` has been added to replace `product`, - `product.state` is now `state.type`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. Fixes #1167 Fixes #1109 Fixes #1174 Fixes #1176
florian-sanders-cc
added a commit
that referenced
this issue
Nov 25, 2024
Smart components: - The `addonFeatures` context parameter of the `cc-pricing-product.smart-addon` component is now optional as it should always have been (default value: `[]` meaning that all features are displayed by default). - The `zoneId` context parameter of both `cc-pricing-product.smart-addon` & `cc-pricing-product.smart-runtime` is now optional (default value: `'par'`). BREAKING CHANGE: the component no longer supports hard coded change rate Prices displayed in pricing components are no longer computed based on hard coded change rate. Prices related to the selected currency come from the API priceSytem endpoint. The component also relies on the new `state` prop for data coming from the API. This means that some types for the component properties have changed: - `currency` is now a `string` (ISO 4217 currency code), - `product` has been removed, - `state` has been added to replace `product`, - `product.state` is now `state.type`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. Fixes #1167 Fixes #1109 Fixes #1174 Fixes #1176
florian-sanders-cc
added a commit
that referenced
this issue
Nov 29, 2024
Smart components: - The `addonFeatures` context parameter of the `cc-pricing-product.smart-addon` component is now optional as it should always have been (default value: `[]` meaning that all features are displayed by default). - The `zoneId` context parameter of both `cc-pricing-product.smart-addon` & `cc-pricing-product.smart-runtime` is now optional (default value: `'par'`). BREAKING CHANGE: the component no longer supports hard coded change rate Prices displayed in pricing components are no longer computed based on hard coded change rate. Prices related to the selected currency come from the API priceSytem endpoint. The component also relies on the new `state` prop for data coming from the API. This means that some types for the component properties have changed: - `currency` is now a `string` (ISO 4217 currency code), - `product` has been removed, - `state` has been added to replace `product`, - `product.state` is now `state.type`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. Fixes #1167 Fixes #1109 Fixes #1174 Fixes #1176
florian-sanders-cc
added a commit
that referenced
this issue
Dec 4, 2024
Smart components: - The `addonFeatures` context parameter of the `cc-pricing-product.smart-addon` component is now optional as it should always have been (default value: `[]` meaning that all features are displayed by default). - The `zoneId` context parameter of both `cc-pricing-product.smart-addon` & `cc-pricing-product.smart-runtime` is now optional (default value: `'par'`). BREAKING CHANGE: the component no longer supports hard coded change rate Prices displayed in pricing components are no longer computed based on hard coded change rate. Prices related to the selected currency come from the API priceSytem endpoint. The component also relies on the new `state` prop for data coming from the API. This means that some types for the component properties have changed: - `currency` is now a `string` (ISO 4217 currency code), - `product` has been removed, - `state` has been added to replace `product`, - `product.state` is now `state.type`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. The payload type of the `cc-pricing-product:add-plan` dispatched event has changed. Plans must now include a `priceId` property to be handled by the `cc-pricing-estimation` correctly. This also means that custom products / plans can no longer be added to the estimation because they are not part of the priceSystem and have no `priceId`. Fixes #1167 Fixes #1109 Fixes #1174 Fixes #1176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
The docs of
cc-pricing-product.smart-addonspecify that theaddonFeaturescan be left out and that this makes the component display all features.This means the
addonFeaturesis optional so we should update the smart component to actually make it optional.The text was updated successfully, but these errors were encountered: