Skip to content

Commit

Permalink
chore(tsconfig-ci): include node library types only
Browse files Browse the repository at this point in the history
TypeScript always checks all types found in the `node_modules/@types`
folder.
It looks like with the new storybook version, some types in there are in
conflict and contain mistakes (storybook & react dependencies).
The common solution is to use `skipLibCheck: true` but this disables
typechecking for all `d.ts` files, including ours.

Fixes #972
  • Loading branch information
florian-sanders-cc committed Mar 5, 2024
1 parent a713bd8 commit c518a1e
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tsconfig.ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,11 @@
"src/lib/utils.js"
],
"extends": "./tsconfig.json",
"compilerOptions": {
// FIXME:
// This means our `d.ts` files are not checked in CI context
// This needs to be set to `true` at least until we can upgrade TypeScript
// see https://github.com/CleverCloud/clever-components/issues/972
"skipLibCheck": true,
}
}

0 comments on commit c518a1e

Please sign in to comment.