Add modularity to widget placement and inclusion #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds the ability to convert the config layout into a usable struct * Also adds the default struct if no config is given
This is in order to deal with TUI overflowing on tables. It's possible a similiar fix will be needed on ALL tables...
Fixes the following issues: - Movement between cpu to legend and proc to search - Graph scaling - Shortcuts for search - Inc/dec count works again - Fixes an issue with painter init and widget position
Need to fix left/right
There is currently a problem with ratios that would allow for irrational fractions. So, if you have, for example, ratios of 1 1 1, then despite all of the sizes technically being the same, they actually fall on the LAST widget, rather than the first, because of rounding. I'll take a look at that and if it is all good then I can work on the other parts of modularity.
Ripped out the auto CPU legend hiding thing (well, it autohides, but not properly)
10 tasks
Also forces cpu legend to always be +1 in terms of id to its corresponding CPU graph
- Add fix for scrolling in processes if it changes. May need to add for other types of scrollables - Fix for process list due to incorrect len() check
Note this commit DISABLES expansion for basic mode. Not worth implementing (again) IMO. Will revisit in the future, probably if I allow basic components to be used in modularity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant, please provide screenshots of what results from the change:
Issue
If applicable, what issue does this address?
Closes: #51
Type of change
Remove the irrelevant ones:
Test methodology
Please state how this was tested:
Testing to repeat on all platforms:
Please tick which platforms this change was tested on:
Checklist
Please ensure all are ticked (and actually done):
Other information
Provide any other relevant information: