-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
other: use custom time chart grid implementation #937
Conversation
Codecov ReportBase: 20.07% // Head: 19.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
==========================================
- Coverage 20.07% 19.64% -0.43%
==========================================
Files 74 75 +1
Lines 14247 14558 +311
==========================================
Hits 2860 2860
- Misses 11387 11698 +311
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Vendors in tui-rs' time chart render logic so I can set a custom logic for braille painting.
121f2bf
to
bf0f5a8
Compare
df179d0
to
9d23e77
Compare
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Pulls in the tui-rs grid logic so I can implement custom braille painting logic. We basically "flatten" the layering logic into a single layer by replacing resetting cells if the colour is different. This avoids the multiple allocations if we used multiple layers as intended with tui-rs.
This gives us chart results similar to the current stable version, but with a flamegraph similar to the current master branch. See (top is this branch, bottom is stable):
Issue
If applicable, what issue does this address?
Closes: #933
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)