Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update clap to 3.x #690

Merged
merged 4 commits into from
Mar 8, 2022
Merged

deps: update clap to 3.x #690

merged 4 commits into from
Mar 8, 2022

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Updates bottom to use clap 3.x.x, along with some small refactoring changes.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Please also indicate which platforms were tested. All platforms directly affected by the change must be tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts

@codecov-commenter
Copy link

Codecov Report

Merging #690 (ae0f6fb) into master (fbd9512) will increase coverage by 0.63%.
The diff coverage is 25.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #690      +/-   ##
=========================================
+ Coverage    7.21%   7.84%   +0.63%     
=========================================
  Files          52      53       +1     
  Lines        8238    8269      +31     
=========================================
+ Hits          594     649      +55     
+ Misses       7644    7620      -24     
Impacted Files Coverage Δ
src/app/data_harvester.rs 0.00% <ø> (ø)
src/app/data_harvester/temperature/heim.rs 0.00% <0.00%> (ø)
src/app/data_harvester/temperature/mod.rs 0.00% <0.00%> (ø)
src/app/data_harvester/temperature/nvidia.rs 0.00% <0.00%> (ø)
src/canvas.rs 0.00% <0.00%> (ø)
src/clap.rs 0.00% <0.00%> (ø)
src/data_conversion.rs 0.00% <ø> (ø)
src/lib.rs 0.00% <ø> (ø)
src/options.rs 0.00% <0.00%> (ø)
src/canvas/drawing_utils.rs 57.29% <92.30%> (+57.29%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e682882...ae0f6fb. Read the comment docs.

@ClementTsang ClementTsang merged commit 01f6bdd into master Mar 8, 2022
@ClementTsang ClementTsang deleted the update_clap branch March 8, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants