Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sysinfo version #658

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Update sysinfo version #658

merged 1 commit into from
Jan 20, 2022

Conversation

GuillaumeGomez
Copy link
Contributor

No description provided.

@ClementTsang
Copy link
Owner

Seems like there's similar problems as with #639 with breaking changes.

@GuillaumeGomez
Copy link
Contributor Author

Interesting that I couldn't trigger it locally... I'll give it another try tomorrow if I don't forget...

@GuillaumeGomez
Copy link
Contributor Author

Updated!

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022 •
edited
Loading

Codecov Report

Merging #658 (4438643) into master (456efdc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #658   +/-   ##
======================================
  Coverage    7.21%   7.21%           
======================================
  Files          52      52           
  Lines        8238    8238           
======================================
  Hits          594     594           
  Misses       7644    7644
Impacted Files Coverage Δ
src/app/data_harvester.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398d52a...4438643. Read the comment docs.

@GuillaumeGomez
Copy link
Contributor Author

Let's hope I didn't forget something again... (Please run CI ^^)

@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Jan 20, 2022 •
edited
Loading

CI is happy! \o/

@ClementTsang ClementTsang mentioned this pull request Jan 20, 2022
Closed
8 tasks
@ClementTsang
Copy link
Owner

LGTM. Thanks for doing this!

Also thanks a ton for the sysinfo library in general!

@all-contributors add @GuillaumeGomez for code

@allcontributors allcontributors bot mentioned this pull request Jan 20, 2022
Merged
@allcontributors
Copy link
Contributor

@ClementTsang

I've put up a pull request to add @GuillaumeGomez! 🎉

@ClementTsang ClementTsang merged commit fbd9512 into ClementTsang:master Jan 20, 2022
@GuillaumeGomez GuillaumeGomez deleted the update-sysinfo branch January 20, 2022 19:28
@GuillaumeGomez
Copy link
Contributor Author

You're very welcome! Thanks for using it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @ClementTsang @codecov-commenter