Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tui-rs 0.11.0 refactor #253

Merged
merged 6 commits into from
Sep 27, 2020
Merged

refactor: tui-rs 0.11.0 refactor #253

merged 6 commits into from
Sep 27, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 26, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Refactors tui-rs usage to the new 0.11.0 release. This release also fixes the highlighting bug from #249, and now, expanding a widget no longer overrides the widget title colour.

This commit also introduces #255, but that seems to be easy to bandaid so hopefully it will get fixed soon?

Issue

If applicable, what issue does this address?

Closes: #252
Closes: #249

Type of change

Remove the irrelevant ones:

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (some change that doesn't change functionality; if relevant state what was changed)

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended - Kinda fails this, but not much I can do about it...
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang
Copy link
Owner Author

ClementTsang commented Sep 26, 2020

To further test:

  • Make sure corner draw bug from v0.10.0 no longer exists.
  • Test long running and resizing.

@ClementTsang ClementTsang merged commit c03f8fe into master Sep 27, 2020
@ClementTsang ClementTsang deleted the tui_0.11.0_release branch September 27, 2020 00:04
ClementTsang added a commit that referenced this pull request Sep 27, 2020
Refactors tui-rs usage to the new 0.11.0 release. This release also fixes the highlighting bug from #249, and now, expanding a widget no longer overrides the widget title colour.

This commit also introduces #255, but that seems to be easy to bandaid so hopefully it will get fixed soon?
@ClementTsang ClementTsang changed the title [refactor] tui-rs 0.11.0 refactor refactor: tui-rs 0.11.0 refactor Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to tui v0.11.0 Fix weird colour on widgets that aren't selected but have a highlighted entry
1 participant