Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove battery conversion step #1652

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Dec 23, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Simplify some of the data-to-display pipeline for battery data; also fix some width bugs.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) December 23, 2024 00:43
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 6.49351% with 72 lines in your changes missing coverage. Please review.

Project coverage is 41.27%. Comparing base (603d8fe) to head (0eccf25).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/data_collection/batteries.rs 0.00% 41 Missing ⚠️
src/canvas/widgets/battery_display.rs 9.67% 28 Missing ⚠️
src/app/data_farmer.rs 0.00% 1 Missing ⚠️
src/canvas/components/data_table/draw.rs 0.00% 1 Missing ⚠️
src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   41.28%   41.27%   -0.01%     
==========================================
  Files         108      108              
  Lines       17898    17893       -5     
==========================================
- Hits         7389     7386       -3     
+ Misses      10509    10507       -2     
Flag Coverage Δ
macos-14 37.28% <6.49%> (+0.01%) ⬆️
ubuntu-latest 42.99% <6.49%> (-0.01%) ⬇️
windows-2019 37.21% <6.49%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the refactor_battery_data branch 2 times, most recently from 5b32afa to 7abd71f Compare December 23, 2024 03:45
@ClementTsang ClementTsang merged commit cd6c60c into main Dec 23, 2024
37 checks passed
@ClementTsang ClementTsang deleted the refactor_battery_data branch December 23, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant