Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up cirrus CI #1530

Merged
merged 7 commits into from
Aug 1, 2024
Merged

ci: clean up cirrus CI #1530

merged 7 commits into from
Aug 1, 2024

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Ideally we add this behaviour back in.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.28%. Comparing base (8811d54) to head (a8bf204).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   41.28%   41.28%           
=======================================
  Files         113      113           
  Lines       17739    17739           
=======================================
  Hits         7323     7323           
  Misses      10416    10416           
Flag Coverage Δ
macos-12 36.71% <ø> (ø)
ubuntu-latest 43.26% <ø> (ø)
windows-2019 36.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the tweak_cirrus_task_cancellation branch from fffcbc6 to 1f28e20 Compare August 1, 2024 23:24
@ClementTsang ClementTsang force-pushed the tweak_cirrus_task_cancellation branch from 1f28e20 to d66b3aa Compare August 1, 2024 23:26
@ClementTsang ClementTsang changed the title ci: try adding auto cancellation back to cirrus tasks ci: clean up cirrus stuff Aug 1, 2024
@ClementTsang ClementTsang changed the title ci: clean up cirrus stuff ci: clean up cirrus CI Aug 1, 2024
@ClementTsang
Copy link
Owner Author

Gonna also maybe look at triggering the tests differently in another PR.

@ClementTsang ClementTsang force-pushed the tweak_cirrus_task_cancellation branch from 8f3cad0 to ce35a7e Compare August 1, 2024 23:52
@ClementTsang ClementTsang merged commit eaff5d0 into main Aug 1, 2024
4 of 6 checks passed
@ClementTsang ClementTsang deleted the tweak_cirrus_task_cancellation branch August 1, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant