Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add .desktop file #1296

Merged
merged 3 commits into from
Sep 6, 2023
Merged

ci: add .desktop file #1296

merged 3 commits into from
Sep 6, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 6, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Adds a .desktop file to the repo, as well as the generated packages + automated release via CI.

Issue

If applicable, what issue does this address?

Closes: #1295

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Tested on my Arch Linux system, seems to show up fine on rofi and launch fine if I copy it over to ~/.local/share/applications.

CI is tested with the following mock nightly run: https://github.com/ClementTsang/bottom/actions/runs/6103067244

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1f41ff3) 31.64% compared to head (00ef1b1) 31.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   31.64%   31.64%           
=======================================
  Files          98       98           
  Lines       16644    16644           
=======================================
  Hits         5267     5267           
  Misses      11377    11377           
Flag Coverage Δ
macos-12 33.37% <ø> (ø)
ubuntu-latest 33.20% <ø> (ø)
windows-2019 33.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang marked this pull request as ready for review September 6, 2023 22:39
@ClementTsang ClementTsang merged commit f38fbf0 into master Sep 6, 2023
@ClementTsang ClementTsang deleted the add_desktop_file branch September 6, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] Implement .desktop file?
1 participant