Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] refactor: use postcss-advanced-variables #107

Merged
merged 4 commits into from
Dec 12, 2019

Conversation

gossi
Copy link
Member

@gossi gossi commented Dec 10, 2019

Adding: postcss-advanced-variables
Remove: postcss-each, postcss-for, postcss-conditionals

I disabled @mixin, @include, @content as I guess it would conflict with postcss-mixins.

Open question here: We might think about using postcss-advanced-variables instead of postcss-mixins, but those from advanced-variables package feel less capable.

@gossi gossi requested a review from buschtoens December 10, 2019 17:01
buschtoens
buschtoens previously approved these changes Dec 11, 2019
Copy link
Member

@buschtoens buschtoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I agree, that postcss-mixins looks a bit more powerful.

@buschtoens buschtoens changed the title Exchange archived plugins for advanced-variables [BREAKING] refactor: use postcss-advanced-variables Dec 12, 2019
@buschtoens buschtoens merged commit 8c34875 into master Dec 12, 2019
@buschtoens buschtoens deleted the advanced-variables branch December 12, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants