Restructure multiline and grouped bar chart functions

[MelinaGoula]

Functions to review:

• horizontal_grouped_bar_chart
• vertical_grouped_bar_chart
• multi_linechart_test
• helper functions (lines 1102 to 1490)

[MelinaGoula]

Comparison of stacked bar chart functions

Previous (stacked_chart)

Rewrite (horizontal_grouped_bar_chart)

Example of (vertical_grouped_bar_chart)

[MelinaGoula]

Functionality that was not carried over from multi_linechart to multi_linechart_test (the temporary new version):

• Ability to set custom styling parameters (font-size, font-family, fontfamily-list, stroke, stroke-width, border)
• Setting a plot title
• Dashed grid lines as opposed to solid grid lines
• Customizable tick length and width
• Customizable sizes for axis and tick labels
• Customizable precision for tick labels
• Ability to set a specific line colour, width and border style
• Option to add shaded areas

Example plot with multi_linechart showing a lot of the functionality

Recreated with multi_linechart_test:

I am not sure how to deal with legend placement in cases like this where there is not a lot of free space. One alternative is to follow the previous format of having multiple columns in the legend which would look like this:

[gabrielwol]

Should this be using calculate_delta? Same comment on line 580.

[gabrielwol]

I am not sure how to deal with legend placement in cases like this where there is not a lot of free space. One alternative is to follow the previous format of having multiple columns in the legend which would look like this:

Have you considered having the legend always outside the plot? This could help with consistency no matter the data being plotted!

[gabrielwol]

Functionality that was not carried over from multi_linechart to multi_linechart_test (the temporary new version):
....
Recreated with multi_linechart_test:

I think the ticks would be an important feature for this graph type which we often use for timeseries. In our demos people are always trying to pinpoint the specific date that graphed events happen. Maybe dark ticks for the labelled points and lighter ticks for the others as a default?

[gabrielwol]

@MelinaGoula your 3 new charting functions are very elegant compared with the old versions, well done! See a few comments above.

[MelinaGoula]

I have made the following changes and I think this is ready for re-review:

• added the option to add minor ticks to the multi line chart function and specify their spacing, e.g.
  
• moved the legend to the outside of plots (for both grouped bar and multiline plots)
  
• added the option for labeled shaded areas, e.g. (for multiline plots)
  

One thing I think can be done in the future to improve the code structure is to not have as many function parameters passed in the helper functions, but this can be probably only be done by refactoring the code.

[gabrielwol]

These changes look great! Well done @MelinaGoula

[radumas]

Got a slight misfire in building Sphinx.

We need the docs/.nojekyll file to remain.

Also looks like we don't need to commit .doctree files (can add this to .gitignore)

The contents of the html folder should be in docs.

Maybe we should change the build config back to building to sphinx/build and have instructions for people to manually copy the contents of html over to docs when they are ready to merge

[radumas]

Lots of changes here but I think this is really going to help clean up the repo!