KK-1065 | fix: fix "yarn generate:graphql" by using graphql-codegen #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr514.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is failed for https://kukkuu-ui-pr514.dev.hel.ninja 😿💢💥💥 |
now "yarn lint", "yarn typecheck", "yarn test" and "yarn generate:graphql" all work and pass some files were left over with broken types, disabled typechecking for those files and marked them with FIXME comment refs KK-1065
karisal-anders
force-pushed
the
KK-1065-fix-graphql-codegen
branch
from
0d25999 to
0abced3
Compare
TestCafe result is success for https://kukkuu-local.api.dev.hel.ninja 😆🎉🎉🎉 |
|
|
KUKKUU-UI branch is deployed to platta: https://kukkuu-ui-pr514.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is failed for https://kukkuu-ui-pr514.dev.hel.ninja 😿💢💥💥 |
|
I'll refactor a bit so the types are easier to manage. |
nikomakela
approved these changes
Dec 21, 2023
Comment on lines
+12
to
+23
| type ChildByIdQueryEnrolmentNodeOccurrence = NonNullable< | ||
| TypeByTypename< | ||
| NonNullable< | ||
| NonNullable< | ||
| NonNullable< | ||
| ChildByIdQuery['child'] | ||
| >['activeInternalAndTicketSystemEnrolments'] | ||
| >['edges'][number] | ||
| >['node'], | ||
| 'EnrolmentNode' | ||
| >['occurrence'] | ||
| >; |
There was a problem hiding this comment.
Yeah, that's a bit monstrous perhaps with the nested NonNullables etc. I'll refactor the types a bit in another PR.
There was a problem hiding this comment.
Refactoring in #515
For example
type ChildByIdQueryEnrolmentNodeOccurrence = NonNullable<
TypeByTypename<
NonNullable<
NonNullable<
NonNullable<
ChildByIdQuery['child']
>['activeInternalAndTicketSystemEnrolments']
>['edges'][number]
>['node'],
'EnrolmentNode'
>['occurrence']
>;→
export type InternalEnrolmentOccurrence = NonNullable<
InternalEnrolment['occurrence']
>;
nikomakela
added a commit
to City-of-Helsinki/kukkuu-admin
that referenced
this pull request
Jan 22, 2024
KK-1076 The Apollo client codegen does not work with the current Node version. Migration guide: https://www.rubrik.com/blog/architecture/23/6/migrating-apollo-codegen-to-graphQL-code-generator Also took the changes done in Kukkuu-UI as an example: - City-of-Helsinki/kukkuu-ui#514 - City-of-Helsinki/kukkuu-ui#515 - City-of-Helsinki/kukkuu-ui#516
nikomakela
added a commit
to City-of-Helsinki/kukkuu-admin
that referenced
this pull request
Jan 24, 2024
KK-1076 The Apollo client codegen does not work with the current Node version. Migration guide: https://www.rubrik.com/blog/architecture/23/6/migrating-apollo-codegen-to-graphQL-code-generator Also took the changes done in Kukkuu-UI as an example: - City-of-Helsinki/kukkuu-ui#514 - City-of-Helsinki/kukkuu-ui#515 - City-of-Helsinki/kukkuu-ui#516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: fix "yarn generate:graphql" by using graphql-codegen
now "yarn lint", "yarn typecheck", "yarn test" and
"yarn generate:graphql" all work and pass
some files were left over with broken types, disabled typechecking for
those files and marked them with FIXME comment
refs KK-1065
Context
KK-1065
How Has This Been Tested?
Manual Testing Instructions for Reviewers
Screenshots