Change CSRF error handling to open login URL in new tab when necessary #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttiikeri
reviewed
Dec 20, 2024
ttiikeri
approved these changes
Dec 20, 2024
indigane
force-pushed
the
feature/frontend-csrf-error-workaround
branch
from
3aa5d19 to
3306064
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitas Pull Request
Description
Sometimes when a user hasn't used Hitas for a while, they get a CSRF error when submitting a form.
The frontend checks for this, and redirects the user to the login page, which will re-set the CSRF token cookie.
This will however clear the form.
This PR changes the check to open the login page in a new window or tab instead and then closes that new window or tab after login letting the user to re-submit the form without clearing it.
Pull request checklist
Check the boxes for each DoD item that has been completed:
Tickets
HT-762