Add default 0 for additional work in unconfirmed prices calculation #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitas Pull Request
Description
If a user does not fill additional work in Apartment form, the unconfirmed prices on the Apartment details page are empty.
Filling in 0 on the form fixes the issue.
This could have been fixed by defaulting the form to 0, but then one of the fields would be inconsistent with the others.
Most of the code already does
additional_work_during_construction or 0
defaulting it to 0 if it is falsy (null).There is one calculation that uses
additional_work_during_construction
without defaulting to 0.This PR changes that calculation to also default to 0, solving the issue on the backend instead of changing one of the form fields.
Pull request checklist
Check the boxes for each DoD item that has been completed:
Tickets
HT-758