Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default 0 for additional work in unconfirmed prices calculation #515

Merged

Conversation

indigane
Copy link
Contributor

Hitas Pull Request

Description

If a user does not fill additional work in Apartment form, the unconfirmed prices on the Apartment details page are empty.

Filling in 0 on the form fixes the issue.

This could have been fixed by defaulting the form to 0, but then one of the fields would be inconsistent with the others.

Most of the code already does additional_work_during_construction or 0 defaulting it to 0 if it is falsy (null).

There is one calculation that uses additional_work_during_construction without defaulting to 0.

This PR changes that calculation to also default to 0, solving the issue on the backend instead of changing one of the form fields.

Pull request checklist

Check the boxes for each DoD item that has been completed:

  • Testing
    • Changes have been tested

Tickets

HT-758

@indigane indigane force-pushed the feature/HT-758-calculation-when-additional-work-null branch from 5c9f677 to 63f2e85 Compare November 21, 2024 12:54
@indigane indigane merged commit 3fc09f5 into master Nov 21, 2024
5 checks passed
@indigane indigane deleted the feature/HT-758-calculation-when-additional-work-null branch November 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants