Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunnistamo to Tunnistus/Helsinkiprofiili #510

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

indigane
Copy link
Contributor

@indigane indigane commented Oct 29, 2024

Hitas Pull Request

Description

This PR implements changes for moving from Tunnistamo to Tunnistus/Helsinkiprofiili.

Mainly this means removing SOCIAL_AUTH_TUNNISTAMO_SCOPE = ["ad_groups"] since the ad_groups scope no longer exists in Tunnistus and is instead included by default.

This PR also adds an on-demand data migration for users as they login if a duplicate user is detected. This will prevent login issues for users who have previously logged in using Tunnistamo.

Pull request checklist

Check the boxes for each DoD item that has been completed:

  • Testing
    • Changes have been tested
    • Automatic tests have been added

Tickets

HT-709

@indigane indigane force-pushed the feature/HT-709-tunnistamo-to-helsinkiprofiili branch from 4d01d01 to 376fa98 Compare October 29, 2024 08:50
@indigane indigane force-pushed the feature/HT-709-tunnistamo-to-helsinkiprofiili branch 6 times, most recently from df614fa to 7afa96f Compare October 30, 2024 10:06
@indigane indigane requested a review from ttiikeri October 30, 2024 10:33
@indigane indigane force-pushed the feature/HT-709-tunnistamo-to-helsinkiprofiili branch from 7afa96f to d2f2d96 Compare October 30, 2024 10:38
Copy link

@indigane indigane requested a review from silenatte November 1, 2024 09:58
@indigane indigane merged commit e18bf61 into master Nov 1, 2024
5 checks passed
@indigane indigane deleted the feature/HT-709-tunnistamo-to-helsinkiprofiili branch November 1, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants