Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Change condition of sale delete button to be always visible #456

Merged
merged 1 commit into from
May 7, 2024

Conversation

indigane
Copy link
Contributor

@indigane indigane commented May 7, 2024

Hitas Pull Request

Käyttäjätarina: Kun asunnolla on myyntiehto, asuntosihteerin pitäisi pystyä se poistamaan ilman myyntiehdon täyttämistä. Poisto tehtäisiin muokkaa myyntiehtoja -näytön kautta, rivin päädyssä olevan poista “painikkeen” kautta.

Painikkeeseen tulee varmistus, että oletko varma, että haluat poistaa myyntiehdon → hyväsyminen.

Hyväksymiskriteerit: Myyntiehto on mahdollista poistaa varmistuksen kautta.

Condition of sale delete button was visible when a person is not listed as an owner for the apartment that the condition of sale points to and when the condition of sale has not yet been fulfilled.

Changed condition of sale delete button to be always visible.

Pull request checklist

Check the boxes for each DoD item that has been completed:

  • Testing
    • Changes have been tested

Tickets

HT-704

@indigane indigane requested a review from ttiikeri May 7, 2024 10:35
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@indigane indigane merged commit 1051bc4 into master May 7, 2024
5 checks passed
@indigane indigane deleted the feature/HT-704-sale-condition-removal branch May 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants