Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIED-122: Add endpoints for liveness & readiness probes #368

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

danipran
Copy link
Contributor

@danipran danipran commented Nov 14, 2023

Description

Add endpoints for liveness & readiness probes.

Related Issue(s)

TIED-122

Motivation and Context

Liveness & readiness probes require endpoints to work.

@danipran danipran requested a review from a team November 14, 2023 11:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a189deb) 95.55% compared to head (1a6823d) 95.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files         104      105    +1     
  Lines        5021     5032   +11     
=======================================
+ Hits         4798     4809   +11     
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danipran danipran force-pushed the TIED-122/add-readiness-health-check branch from b9889dd to 1a6823d Compare November 14, 2023 11:16
@danipran danipran force-pushed the TIED-122/add-readiness-health-check branch from 1a6823d to 4d0b5bf Compare November 14, 2023 11:23
@danipran danipran requested a review from voneiden November 14, 2023 11:23
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

#
# Kubernetes liveness & readiness probes
#
@require_safe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this for Sonarcloud.

Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@danipran danipran merged commit 364e390 into main Nov 15, 2023
@danipran danipran deleted the TIED-122/add-readiness-health-check branch November 15, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants