-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIED-60: Upgrade Python to 3.9, upgrade package versions, add DEFAULT_AUTO_FIELD #341
Conversation
compose.yaml is the preferred path nowadays: https://docs.docker.com/compose/compose-file/#compose-file
a97c3fb
to
f8f43d6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #341 +/- ##
===========================================
+ Coverage 93.61% 93.89% +0.27%
===========================================
Files 147 149 +2
Lines 5231 5467 +236
===========================================
+ Hits 4897 5133 +236
Misses 334 334
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README needs to be updated
Kudos, SonarCloud Quality Gate passed! |
New deprecation warnings for some dependencies @ https://github.com/City-of-Helsinki/helerm/actions/runs/4374218764/jobs/7653368407#step:8:207
Wanna deal with these now or later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed files LGTM
Might as well take a closer look at this, seems like this is something that's coming sooner than later 😅 However, this seems to be out of this PR's scope for the time being, so not resolving this problem in this PR. |
Description
DEFAULT_AUTO_FIELD
in Django settings and related migrations.Related Issue(s)
TIED-60
Motivation and Context
Python 3.7's support ends in June 2023, so we want to upgrade it to a fresher version. Some of the packages have already dropped support for 3.7 as well, so this enables us to update them as well.
How Has This Been Tested?
Locally, running Docker container and the unit tests w/ warnings enabled:
Additional Notes
The original plan was to upgrade Django to 4.1 as well, but it turns out that django-helusers doesn't support Django >=4, so postponing that...