TIED-46: Apply code QA tools (black, isort), fix/ignore flake8 errors #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors being: ./metarecord/exporter/jhs.py:96:10: N806 variable 'ToimenpideTiedot' in function should be lowercase ./metarecord/exporter/jhs.py:112:10: N806 variable 'ToimenpideTiedot' in function should be lowercase ./metarecord/exporter/jhs.py:142:5: C901 'JHSExporter._handle_classification' is too complex (12)
Following errors: ./metarecord/views/admin.py:21:38: B006 Do not use mutable data structures for argument defaults. They are created during function definition time. All calls to the function reuse this one instance of that data structure, persisting changes between them. ./metarecord/importer/tos.py:104:10: N806 variable 'HEADER_ROW' in function should be lowercase ./metarecord/importer/tos.py:105:10: N806 variable 'VALUE_ROW' in function should be lowercase
voneiden
approved these changes
Feb 22, 2023
Due to flake8 error: ./metarecord/views/function.py:86:5: C901 'FunctionListSerializer._create_new_version' is too complex (12)
TOSImporter._process_data TOSImporter.import_attributes get_attribute_json_schema Errors: ./metarecord/importer/tos.py:322:5: C901 'TOSImporter._process_data' is too complex (21) ./metarecord/importer/tos.py:431:5: C901 'TOSImporter.import_attributes' is too complex (15) ./metarecord/models/structural_element.py:214:1: C901 'get_attribute_json_schema' is too complex (16)
danipran
force-pushed
the
TIED-46-apply-code-qa
branch
from
d2b78b8 to
188b7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mass applied black/isort code formatting. Fixed the flake8 errors manually.
Regarding C901 errors (too complex); tried to split some of the low-hanging fruits. Added
# noqa: C901for parts that weren't clear-cut cases.The "low-hanging fruits" (might wanna check these more carefully):
865f4b1
77791fb