Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-11235: Events near you #1177

Merged
merged 26 commits into from
Feb 10, 2025
Merged

UHF-11235: Events near you #1177

merged 26 commits into from
Feb 10, 2025

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Feb 7, 2025 •
edited by jira bot
Loading

UHF-11235

Extend linkedevents app to include functionality for Helsinki near you events page.

What was done

  • Add common hook for gettings address coordinates
  • Fix new HDS selects rendering issues
  • Add types for API responses + more
  • Add new componens for the feature

Check detailed install & testing info here: City-of-Helsinki/drupal-helfi-etusivu#844

Other PRs

jeremysteerio and others added 20 commits February 6, 2025 19:00
@jeremysteerio
UHF-11235: Near you events base
15e1420 
- Add global common hook for address queries
- Fix issues with select component
@jeremysteerio
UHF-11235: Make locations filter searchable
4a0ae7c
@jeremysteerio
UHF-11235: Memoize selects
16a88b8
@jeremysteerio
UHF-11235: Selections work
91dde95
@jeremysteerio
UHF-11235: Hide pills when using selections with search
1d79b5e
@jeremysteerio
UHF-11235: Workaround rendering issues with select components
a689bff
@jeremysteerio
UHF-11235: Use searchinput for address suggesting
f4c84b2
@jeremysteerio
UHF-11235: Add reading initial address from query string
0dacf34
@jeremysteerio
UHF-11235: Bump event list version
88ea1bc
@jeremysteerio
UHF-11235: Add override for all events link
4526824
@jeremysteerio
UHF-11235: Helsinki near you events page tweaks
26d5e81
@jeremysteerio
UHF-11235: Helsinki near you events form styles
a5d85fd
@jeremysteerio
UHF-11235: Remove unused hook
2950149
@jeremysteerio
UHF-11235: Add better message for missing address
84e72ce
@jeremysteerio
UHF-11235: Fix translation context
6facace
@jeremysteerio
Add consistent bottom margin to hdbt filters
c3c629f
@teroelonen
UHF-11235: Adjusted spacing a to be a bit more consistent
66d173a
@jeremysteerio
UHF-11235: Add consistent bottom margin to hdbt filters
2d7c840
@teroelonen @jeremysteerio
UHF-11235: Adjusted spacing a to be a bit more consistent
1214c13
@jeremysteerio
UHF-11235: Wrap checkboxes in fieldset, remove legacy styles
679821f
@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

teroelonen
teroelonen approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this 🦖

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1177/html_report/

@jeremysteerio jeremysteerio merged commit 59944de into main Feb 10, 2025
2 checks passed
@jeremysteerio jeremysteerio deleted the UHF-11235 branch February 10, 2025 13:00
This was referenced Feb 10, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremysteerio @teroelonen