Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11325: Adding unique link texts for map skip links #1172

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 4, 2025

UHF-11325

What was done

  • Changed the map skip links to have the map title in the link text if title is provided. This is for accessibility 2.4.4: Link Purpose (In Context).

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11325
  • Run make drush-locale-update drush-cr

How to test

  • Create a new basic page or view a existing one with map paragraph. If the map paragraph has title the title should be in the skip link text in the @map variable Continue above the @map map. If no title is set the text on the link should be Continue above the map. This should work on all three languages.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated.
  • This change doesn't require updates to the documentation.

Translations

  • Translations have been added to .po -files and included in this PR

@khalima khalima added recreate-reference-images Use this label to re-create reference images used by Visual regression tests install-drupal-from-scratch Select this to install Drupal from scratch in visual regression tests and removed recreate-reference-images Use this label to re-create reference images used by Visual regression tests labels Feb 4, 2025
Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install-drupal-from-scratch Select this to install Drupal from scratch in visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants