Skip to content

Commit

Permalink
fix: default value of a variable of type integer or float should be 0…
Browse files Browse the repository at this point in the history 
… instead of null
  • Loading branch information
@Marcelh1983
Marcelh1983 committed Jan 31, 2025
1 parent b0db799 commit 46aa98e
Show file tree
Hide file tree
Showing 2 changed files with 208 additions and 0 deletions.
199 changes: 199 additions & 0 deletions ...ti-response-processing/qti-rule/qti-lookup-outcome-value/qti-lookup-outcome-value.spec.ts
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,199 @@
import { html, render } from 'lit';
import { expect, describe, it, vi } from 'vitest';

import './../../../index';
import type { QtiLookupOutcomeValue } from './qti-lookup-outcome-value';

describe('qti-lookup-outcome-value', () => {
function setupQtiAssessmentItem2() {
const container = document.createElement('div'); // Create a new container for each test
document.body.appendChild(container);
const template = html`<qti-assessment-item
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.imsglobal.org/xsd/imsqtiasi_v3p0 https://purl.imsglobal.org/spec/qti/v3p0/schema/xsd/imsqti_asiv3p0_v1p0.xsd
http://www.w3.org/1998/Math/MathML https://purl.imsglobal.org/spec/mathml/v3p0/schema/xsd/mathml3.xsd
http://www.w3.org/2001/10/synthesis https://purl.imsglobal.org/spec/ssml/v1p1/schema/xsd/ssmlv1p1-core.xsd"
title="Ik heb een stomme naam 3"
time-dependent="false"
adaptive="false"
identifier="_eb6b2d2b-5548-49fa-b73a-217b8e62ed35"
label="20011 D "
xml:lang="nl-NL"
xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0"
>
<qti-response-declaration identifier="RESPONSE" cardinality="single" base-type="identifier">
<qti-correct-response interpretation="B">
<qti-value>B</qti-value>
</qti-correct-response>
</qti-response-declaration>
<qti-outcome-declaration identifier="RAWSCORE" cardinality="single" base-type="float"></qti-outcome-declaration>
<qti-outcome-declaration identifier="SCORE" cardinality="single" base-type="float">
<qti-interpolation-table>
<qti-interpolation-table-entry target-value="1" source-value="1"></qti-interpolation-table-entry>
<qti-interpolation-table-entry target-value="0" source-value="0"></qti-interpolation-table-entry>
</qti-interpolation-table>
</qti-outcome-declaration>
<qti-outcome-declaration identifier="MAXSCORE" cardinality="single" base-type="float">
<qti-default-value>
<qti-value>1</qti-value>
</qti-default-value>
</qti-outcome-declaration>
<qti-assessment-stimulus-ref
identifier="_86bee4be-0126-43f1-aea6-87207b42ab9e"
href="Stimulus/86bee4be-0126-43f1-aea6-87207b42ab9e.xml"
></qti-assessment-stimulus-ref>
<qti-item-body>
<div class="qti-layout-row">
<div class="qti-layout-col6">
<div class="qti-shared-stimulus" data-stimulus-idref="_86bee4be-0126-43f1-aea6-87207b42ab9e"></div>
</div>
<div class="qti-layout-col6">
<div class="question">
<p>Lees: De jongen &#x2026; boos aan. (r. 2 en 3)</p>
<p>Wat hoort op de puntjes (&#x2026;) te staan?</p>
</div>
<qti-choice-interaction max-choices="1" min-choices="0" shuffle="false" response-identifier="RESPONSE">
<qti-simple-choice identifier="A"
><p xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0">Ik ben ontspannen</p></qti-simple-choice
>
<qti-simple-choice identifier="B"
><p xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0">Ik moet &#x2018;m niet</p></qti-simple-choice
>
<qti-simple-choice identifier="C"
><p xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0">Ik vind &#x2018;m leuk</p></qti-simple-choice
>
<qti-simple-choice identifier="D"
><p xmlns="http://www.imsglobal.org/xsd/imsqtiasi_v3p0">Ik kwispel blij</p></qti-simple-choice
>
</qti-choice-interaction>
</div>
</div>
</qti-item-body>
<qti-response-processing>
<qti-response-condition>
<qti-response-if>
<qti-member>
<qti-base-value base-type="identifier">B</qti-base-value>
<qti-multiple>
<qti-variable identifier="RESPONSE"></qti-variable>
</qti-multiple>
</qti-member>
<qti-set-outcome-value identifier="RAWSCORE">
<qti-sum>
<qti-variable identifier="RAWSCORE"></qti-variable>
<qti-base-value base-type="float">1</qti-base-value>
</qti-sum>
</qti-set-outcome-value>
</qti-response-if>
</qti-response-condition>
<qti-lookup-outcome-value identifier="SCORE">
<qti-variable identifier="RAWSCORE"></qti-variable>
</qti-lookup-outcome-value>
</qti-response-processing>
</qti-assessment-item>`;

render(template, container); // Render into the new container
return container.querySelector('qti-assessment-item');
}

function setupQtiAssessmentItem() {
const container = document.createElement('div'); // Create a new container for each test
document.body.appendChild(container);
const template = html`
<qti-assessment-item>
<qti-outcome-declaration identifier="RAW_SCORE" cardinality="single" base-type="integer">
<qti-default-value>
<qti-value>0</qti-value>
</qti-default-value>
</qti-outcome-declaration>
<qti-outcome-declaration identifier="SCORE" cardinality="single" base-type="float">
<qti-interpolation-table>
<qti-interpolation-table-entry
include-boundary="false"
source-value="3"
target-value="2"
></qti-interpolation-table-entry>
<qti-interpolation-table-entry
include-boundary="false"
source-value="2"
target-value="1"
></qti-interpolation-table-entry>
<qti-interpolation-table-entry
include-boundary="false"
source-value="1"
target-value="0"
></qti-interpolation-table-entry>
<qti-interpolation-table-entry
include-boundary="false"
source-value="0"
target-value="0"
></qti-interpolation-table-entry>
</qti-interpolation-table>
</qti-outcome-declaration>
<qti-response-processing>
<qti-lookup-outcome-value identifier="SCORE">
<qti-variable identifier="RAW_SCORE"></qti-variable>
</qti-lookup-outcome-value>
</qti-response-processing>
</qti-assessment-item>
`;
render(template, container); // Render into the new container
return container.querySelector('qti-assessment-item');
}

it('should interpolate RAW_SCORE to SCORE correctly', () => {
const assessmentItem = setupQtiAssessmentItem();
assessmentItem.updateOutcomeVariable('RAW_SCORE', '2');
const lookupOutcomeValue = assessmentItem!.querySelector('qti-lookup-outcome-value') as QtiLookupOutcomeValue;

const result = lookupOutcomeValue.process();
expect(result).toBe(1);
});

it('should return 0 if RAW_SCORE is not found in interpolation table', () => {
const assessmentItem = setupQtiAssessmentItem();

const lookupOutcomeValue = assessmentItem!.querySelector('qti-lookup-outcome-value') as QtiLookupOutcomeValue;

assessmentItem.updateOutcomeVariable('RAW_SCORE', '1');
const result = lookupOutcomeValue.process();

expect(result).toBe(0);
});

it('should correctly handle missing interpolation table', () => {
const assessmentItem = setupQtiAssessmentItem();

const lookupOutcomeValue = assessmentItem!.querySelector('qti-lookup-outcome-value') as QtiLookupOutcomeValue;

assessmentItem.updateOutcomeVariable('RAW_SCORE', '0');

const result = lookupOutcomeValue.process();
expect(result).toBe(0);
});

it('score correct with RESPONSE B', () => {
const assessmentItem = setupQtiAssessmentItem2();

const lookupOutcomeValue = assessmentItem!.querySelector('qti-lookup-outcome-value') as QtiLookupOutcomeValue;

assessmentItem.updateResponseVariable('RESPONSE', 'B');
assessmentItem.processResponse();

const result = lookupOutcomeValue.process();
expect(result).toBe(1);
});

it('score correct with RESPONSE A', () => {
const assessmentItem = setupQtiAssessmentItem2();

const lookupOutcomeValue = assessmentItem!.querySelector('qti-lookup-outcome-value') as QtiLookupOutcomeValue;

assessmentItem.updateResponseVariable('RESPONSE', 'A');
assessmentItem.processResponse();

const result = lookupOutcomeValue.process();
expect(result).toBe(0);
});
});
9 changes: 9 additions & 0 deletions ...ti-components/qti-variable-declaration/qti-outcome-declaration/qti-outcome-declaration.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,16 @@ export class QtiOutcomeDeclaration extends QtiVariableDeclaration {
interpolationTable: this.interpolationTable,
externalScored: this.externalScored
};
// At runtime, outcome variables are instantiated as part of an item session.
// Their values may be initialized with a default value and/or set during response processing.
// If no default value is given in the declaration then the outcome variable is initialized to NULL unless the outcome is of a numeric type (integer or float) in which case it is initialized to 0.
outcomeVariable.value = this.defaultValues(outcomeVariable);
if (
(outcomeVariable.value === null || outcomeVariable.value == undefined) &&
(outcomeVariable.baseType === 'integer' || outcomeVariable.baseType === 'float')
) {
outcomeVariable.value = '0';
}
this.dispatchEvent(
new CustomEvent('qti-register-variable', {
bubbles: true,
Expand Down

0 comments on commit 46aa98e

Please sign in to comment.