feat: default value of rubric is now inline, discretionary-placement …

…is stylable
Citolab · Feb 14, 2025 · 23c65b2 · 23c65b2
1 parent 5040077
commit 23c65b2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/src/lib/qti-components/qti-item-body/qti-item-body.ts b/src/lib/qti-components/qti-item-body/qti-item-body.ts
@@ -20,7 +20,7 @@ export class QtiItemBody extends LitElement {
   static styles: CSSResultGroup = styles;
 
   override render() {
-    return html`<slot name="qti-rubric-block"></slot><slot></slot>`;
+    return html`<slot part="qti-rubric-block" name="qti-rubric-block"></slot><slot></slot>`;
   }
 }
 

diff --git a/src/lib/qti-components/qti-rubric-block/qti-rubric-block.ts b/src/lib/qti-components/qti-rubric-block/qti-rubric-block.ts
@@ -38,12 +38,6 @@ export class QtiRubricBlock extends LitElement {
   override render() {
     return html`<slot></slot>`;
   }
-
-  override connectedCallback(): void {
-    super.connectedCallback();
-    // by default put this in a slot in the item-body
-    this.setAttribute('slot', 'qti-rubric-block');
-  }
 }
 
 declare global {

diff --git a/tsup.config.ts b/tsup.config.ts
@@ -1,9 +1,11 @@
-import type { Options } from 'tsup';
 import { defineConfig } from 'tsup';
 import { globby } from 'globby';
+
 import pkgJson from './package.json' assert { type: 'json' };
 import { InlineCSSPlugin } from './scripts/inline-css-plugin';
 
+import type { Options } from 'tsup';
+
 const peerDependencies = Object.keys(pkgJson.peerDependencies || {});
 
 const npmOptions: Options = {