Add AIX variables for the load module function to work in AIX.

[KamathForAIX]

Closes #1435.

[kwwcb]

Hi @KamathForAIX thank you for this fix. You mentioned that the pow() function is linking to the wrong one (libbsd vs libc). Is there a way to fix this without recompiling? For example, creating and adding the right library to LD_LIBRARY_PATH?

[KamathForAIX]

@kwwcb We have to recompile. No other way.

@micahsnyder Any update/comment for the PR?

[val-ms]

I don't have any objection to this change though I will have to trust you to test that it works right for AIX.

I've made some suggestions to fix the formatting and reduce a couple lines of duplicate code.

[val-ms]

Suggested change

	ld_library_path = getenv("LD_LIBRARY_PATH");
	#ifdef _AIX
	ld_library_path = getenv("LIBPATH");
	#endif /* AIX */
	#ifdef _AIX
	ld_library_path = getenv("LIBPATH");
	#else
	ld_library_path = getenv("LD_LIBRARY_PATH");
	#endif

[val-ms]

Suggested change

	snprintf(modulename, sizeof(modulename), "%s" PATHSEP "%s%s", tokens[token_index], name, suffixes[i]);
	rhandle = dlopen(modulename, RTLD_NOW);
	#ifdef _AIX
	snprintf(modulename, sizeof(modulename), "%s%s(%s%s.%d)",name,".a",name,LT_MODULE_EXT,LIBCLAMAV_MAJORVER);
	rhandle = dlopen(modulename, RTLD_NOW);
	#endif /* AIX */
	#ifdef _AIX
	snprintf(modulename, sizeof(modulename),
	"%s%s(%s%s.%d)",
	name, ".a", name, LT_MODULE_EXT, LIBCLAMAV_MAJORVER);
	#else
	snprintf(modulename, sizeof(modulename),
	"%s" PATHSEP "%s%s",
	tokens[token_index], name, suffixes[i]);
	#endif
	rhandle = dlopen(modulename, RTLD_NOW);

[val-ms]

GitHub isn't allowing me to make a suggestion here because of the deleted line between sprintf and rhandle. 🤷 But you should do the same as I suggested above, with #ifdef + #else, and also cleaning up the formatting.

[KamathForAIX]

@val-ms Kindly check now. I have made the changes.

[KamathForAIX]

@val-ms Any updates on this PR? Kindly let me know.

[val-ms]

I'm happy with what I see on github. I wanted to run it through our Jenkins but we had an unexpected issue with our build pipeline on macOS last week after an upgrade, so I haven't been able to run the build. I'll run it again as soon as I'm able.