added safety for reverse attr set function

CircuitMusicLabs · Aug 17, 2018 · e59b1c7 · e59b1c7
1 parent 7376b33
commit e59b1c7
Show file tree

Hide file tree

Showing 16 changed files with 48 additions and 4 deletions.
diff --git a/externals/cm.buffercloud~.mxe b/externals/cm.buffercloud~.mxe
diff --git a/externals/cm.buffercloud~.mxe64 b/externals/cm.buffercloud~.mxe64
diff --git a/externals/cm.buffercloud~.mxo/Contents/MacOS/cm.buffercloud~ b/externals/cm.buffercloud~.mxo/Contents/MacOS/cm.buffercloud~
diff --git a/externals/cm.gausscloud~.mxe b/externals/cm.gausscloud~.mxe
diff --git a/externals/cm.gausscloud~.mxe64 b/externals/cm.gausscloud~.mxe64
diff --git a/externals/cm.gausscloud~.mxo/Contents/MacOS/cm.gausscloud~ b/externals/cm.gausscloud~.mxo/Contents/MacOS/cm.gausscloud~
diff --git a/externals/cm.indexcloud~.mxe b/externals/cm.indexcloud~.mxe
diff --git a/externals/cm.indexcloud~.mxe64 b/externals/cm.indexcloud~.mxe64
diff --git a/externals/cm.indexcloud~.mxo/Contents/MacOS/cm.indexcloud~ b/externals/cm.indexcloud~.mxo/Contents/MacOS/cm.indexcloud~
diff --git a/externals/cm.livecloud~.mxe b/externals/cm.livecloud~.mxe
diff --git a/externals/cm.livecloud~.mxe64 b/externals/cm.livecloud~.mxe64
diff --git a/externals/cm.livecloud~.mxo/Contents/MacOS/cm.livecloud~ b/externals/cm.livecloud~.mxo/Contents/MacOS/cm.livecloud~
diff --git a/source/cm.buffercloud~/cm.buffercloud~.c b/source/cm.buffercloud~/cm.buffercloud~.c
@@ -1232,7 +1232,18 @@ t_max_err cmbuffercloud_zero_set(t_cmbuffercloud *x, t_object *attr, long ac, t_
 /************************************************************************************************************************/
 t_max_err cmbuffercloud_reverse_set(t_cmbuffercloud *x, t_object *attr, long ac, t_atom *av) {
 	if (ac && av) {
-		x->attr_reverse = atom_getsym(av);
+		t_symbol *arg = atom_getsym(av);
+		t_symbol *off = gensym("off");
+		t_symbol *on = gensym("on");
+		t_symbol *random = gensym("random");
+		t_symbol *direction = gensym("direction");
+		if (arg != off && arg != on && arg != random && arg != direction) {
+			object_error((t_object *)x, "invalid attribute value");
+			object_error((t_object *)x, "valid attribute values are off | on | random | direction");
+		}
+		else {
+			x->attr_reverse = arg;
+		}
 	}
 	return MAX_ERR_NONE;
 }

diff --git a/source/cm.gausscloud~/cm.gausscloud~.c b/source/cm.gausscloud~/cm.gausscloud~.c
@@ -1219,7 +1219,18 @@ t_max_err cmgausscloud_zero_set(t_cmgausscloud *x, t_object *attr, long ac, t_at
 /************************************************************************************************************************/
 t_max_err cmgausscloud_reverse_set(t_cmgausscloud *x, t_object *attr, long ac, t_atom *av) {
 	if (ac && av) {
-		x->attr_reverse = atom_getsym(av);
+		t_symbol *arg = atom_getsym(av);
+		t_symbol *off = gensym("off");
+		t_symbol *on = gensym("on");
+		t_symbol *random = gensym("random");
+		t_symbol *direction = gensym("direction");
+		if (arg != off && arg != on && arg != random && arg != direction) {
+			object_error((t_object *)x, "invalid attribute value");
+			object_error((t_object *)x, "valid attribute values are off | on | random | direction");
+		}
+		else {
+			x->attr_reverse = arg;
+		}
 	}
 	return MAX_ERR_NONE;
 }

diff --git a/source/cm.indexcloud~/cm.indexcloud~.c b/source/cm.indexcloud~/cm.indexcloud~.c
@@ -1362,7 +1362,18 @@ t_max_err cmindexcloud_zero_set(t_cmindexcloud *x, t_object *attr, long ac, t_at
 /************************************************************************************************************************/
 t_max_err cmindexcloud_reverse_set(t_cmindexcloud *x, t_object *attr, long ac, t_atom *av) {
 	if (ac && av) {
-		x->attr_reverse = atom_getsym(av);
+		t_symbol *arg = atom_getsym(av);
+		t_symbol *off = gensym("off");
+		t_symbol *on = gensym("on");
+		t_symbol *random = gensym("random");
+		t_symbol *direction = gensym("direction");
+		if (arg != off && arg != on && arg != random && arg != direction) {
+			object_error((t_object *)x, "invalid attribute value");
+			object_error((t_object *)x, "valid attribute values are off | on | random | direction");
+		}
+		else {
+			x->attr_reverse = arg;
+		}
 	}
 	return MAX_ERR_NONE;
 }

diff --git a/source/cm.livecloud~/cm.livecloud~.c b/source/cm.livecloud~/cm.livecloud~.c
@@ -1358,7 +1358,18 @@ t_max_err cmlivecloud_zero_set(t_cmlivecloud *x, t_object *attr, long ac, t_atom
 /************************************************************************************************************************/
 t_max_err cmlivecloud_reverse_set(t_cmlivecloud *x, t_object *attr, long ac, t_atom *av) {
 	if (ac && av) {
-		x->attr_reverse = atom_getsym(av);
+		t_symbol *arg = atom_getsym(av);
+		t_symbol *off = gensym("off");
+		t_symbol *on = gensym("on");
+		t_symbol *random = gensym("random");
+		t_symbol *direction = gensym("direction");
+		if (arg != off && arg != on && arg != random && arg != direction) {
+			object_error((t_object *)x, "invalid attribute value");
+			object_error((t_object *)x, "valid attribute values are off | on | random | direction");
+		}
+		else {
+			x->attr_reverse = arg;
+		}
 	}
 	return MAX_ERR_NONE;
 }